/*
* Copyright 1998-2003 VIA Technologies, Inc. All Rights Reserved.
* Copyright 2001-2003 S3 Graphics, Inc. All Rights Reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sub license,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the
* next paragraph) shall be included in all copies or substantial portions
* of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
* VIA, S3 GRAPHICS, AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include "via.h"
#include "drmP.h"
#include "via_drm.h"
#include "via_drv.h"
int via_do_init_map(drm_device_t * dev, drm_via_init_t * init)
{
drm_via_private_t *dev_priv;
DRM_DEBUG("%s\n", __FUNCTION__);
via_init_command_verifier();
dev_priv = DRM(alloc) (sizeof(drm_via_private_t), DRM_MEM_DRIVER);
if (dev_priv == NULL)
return -ENOMEM;
memset(dev_priv, 0, sizeof(drm_via_private_t));
DRM_GETSAREA();
if (!dev_priv->sarea) {
DRM_ERROR("could not find sarea!\n");
dev->dev_private = (void *)dev_priv;
via_do_cleanup_map(dev);
return -EINVAL;
}
dev_priv->fb = drm_core_findmap(dev, init->fb_offset);
if (!dev_priv->fb) {
DRM_ERROR("could not find framebuffer!\n");
dev->dev_private = (void *)dev_priv;
via_do_cleanup_map(dev);
return -EINVAL;
}
dev_priv->mmio = drm_core_findmap(dev, init->mmio_offset);
if (!dev_priv->mmio) {
DRM_ERROR("could not find mmio region!\n");
dev->dev_private = (void *)dev_priv;
via_do_cleanup_map(dev);
return -EINVAL;
}
dev_priv->sarea_priv =
(drm_via_sarea_t *) ((u8 *) dev_priv->sarea->handle +
init->sarea_priv_offset);
dev_priv->agpAddr = init->agpAddr;
via_init_futex( dev_priv );
dev_priv->pro_group_a = (dev->pdev->device == 0x3118);
dev->dev_private = (void *)dev_priv;
return 0;
}
int via_do_cleanup_map(drm_device_t * dev)
{
if (dev->dev_private) {
drm_via_private_t *dev_priv = dev->dev_private;
via_dma_cleanup(dev);
DRM(free) (dev_priv, sizeof(drm_via_private_t), DRM_MEM_DRIVER);
dev->dev_private = NULL;
}
return 0;
}
int via_map_init(DRM_IOCTL_ARGS)
{
DRM_DEVICE;
drm_via_init_t init;
DRM_DEBUG("%s\n", __FUNCTION__);
DRM_COPY_FROM_USER_IOCTL(init, (drm_via_init_t *) data, sizeof(init));
switch (init.func) {
case VIA_INIT_MAP:
return via_do_init_map(dev, &init);
case VIA_CLEANUP_MAP:
return via_do_cleanup_map(dev);
}
return -EINVAL;
}
>
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
Multimedia-chat-meeting-2019-05-09
10:10 < pinchartl> welcome to the multimedia meeting
10:10 < pinchartl> Topic 1. Status Check for the Multimedia Tasks
10:10 < pinchartl> * Jacopo
10:10 < pinchartl> Since last meeting:
10:10 < pinchartl> - CMM plumbing
10:10 < pinchartl> [RFC 0/9] drm: rcar-du: Add CMM support to M3-W (plumbing only)
10:10 < pinchartl> CMM support patches have been sent by Bosh in a form not consumable by
10:10 < pinchartl> upstream. Provide plumbing to integrate DU and CMM. RFC as the actual
10:10 < pinchartl> CMM driver does nothing ATM.
10:10 < pinchartl> - More and more discussion on v4l2-mux: v5 is ready but not sent yet
10:10 < pinchartl> - Investigated RZ/A JCU unit
10:10 < pinchartl> - Investigated RZ/A video decoder support
10:10 < pinchartl> - Patch review on linux-media
10:10 < pinchartl> Until next meeting:
10:10 < pinchartl> - One week holiday
10:10 < pinchartl> - More CMM work if any feedback is received
10:10 < pinchartl> - Would like to test V4l2-mux with a GMSL setup
10:10 < pinchartl> Issues and blockers: None
10:10 < pinchartl> jmondi: any comment?
10:11 < jmondi> not really
10:11 < pinchartl> thank you
10:11 < pinchartl> * Kieran
10:11 < pinchartl> Since last meeting:
10:11 < pinchartl> - PA-Phase review and update
10:11 < pinchartl> - DU Group refactor debugging
10:11 < pinchartl> Until next meeting:
10:11 < pinchartl> - Post a new (final?) PA-Phase series
10:11 < pinchartl> - Fix DU Group refactor series
10:11 < pinchartl> Issues and blockers: None
10:11 < pinchartl> kbingham: any comment ?
10:12 < kbingham> I see we have an update from morimoto-san about the pa-phase UDS calculation.
10:12 < kbingham> Which is helpful thankyou morimoto :)
10:12 < kbingham> But doesn't particularly give us a clear answer.
10:13 < kbingham> Otherwise status update is fine.
10:13 < pinchartl> let's continue that discusion over e-mail then
10:13 < pinchartl> thank you
10:13 < pinchartl> * Laurent
10:13 < pinchartl> Since last meeting:
10:13 < pinchartl> - Prepared the LVDS dual-link prototype for merge
10:13 < pinchartl> - Manage CMM driver work with Jacopo
10:13 < pinchartl> - Patch review
10:13 < pinchartl> Until next meeting:
10:13 < pinchartl> - Get the LVDS dual-link prototype merged
10:13 < pinchartl> - Merge the VSP partition algorithm improvements
10:13 < pinchartl> Issues and blockers: None
10:13 < pinchartl> any question ?
10:14 < pinchartl> * Morimoto-san
10:14 < pinchartl> Since last meeting:
10:14 < pinchartl> - ALSA SoC framework cleanups
10:14 < pinchartl> The ALSA SoC framework grew organically. Its numerous features are not
10:14 < pinchartl> always cleanly connect, with the underlying code not very readable, and
10:14 < pinchartl> wastefully complicated. For this reason one of the R-Car sound feature
10:14 < pinchartl> can only be half-supported. ALSA SoC cleanups are need to fix that and
10:14 < pinchartl> move to 100% support. Discussions are ongoing with the ALSA soC
10:14 < pinchartl> maintainer on how to fix this.
10:14 < pinchartl> Until next meeting:
10:14 < pinchartl> - Continue with ALSA SoC work
10:14 < pinchartl> Issues and Blockers: None
10:14 < pinchartl> morimoto: any comment ?
10:16 < morimoto> no. thanks
10:16 < pinchartl> thank you
10:16 < pinchartl> * Niklas
10:16 < pinchartl> Since last meeting:
10:16 < pinchartl> - Started work on cleaning up VIN format handling
10:16 < pinchartl> - Prepared VIN fops v2
10:16 < pinchartl> Until next meeting:
10:16 < pinchartl> - Keep cleaning up the VIN crop and compose code
10:16 < pinchartl> This is needed to merge UDS and PM support.
10:16 < pinchartl> Issues and blockers: None
10:16 < pinchartl> neg: any comment ?
10:18 < pinchartl> ah Niklas is attending a conference today
10:18 < pinchartl> * Simon
10:18 < pinchartl> Since last meeting:
10:18 < pinchartl> - Applied "[PATCH] arm64: dts: renesas: draak: Remove unecessary index
10:18 < pinchartl> from vin4 port"
10:18 < pinchartl> Until next meeting: None
10:18 < pinchartl> Issues and Blockers:
10:18 < pinchartl> - Kaneko-san is looking for up-porting candidates
10:18 < pinchartl> and Simon has left already
10:18 < pinchartl> * Ulrich
10:18 < pinchartl> Since last meeting: None
10:18 < pinchartl> Until next meeting: None
10:18 < pinchartl> Issues and Blockers: None
10:18 < pinchartl> uli___: correct?
10:18 < pinchartl> if so I assume there's no special comment :)
10:20 < pinchartl> any discussion point for today ?
10:21 < kbingham> only UDS overlap for me - but that might be suited to email.
10:22 < pinchartl> we have some time now
10:22 < pinchartl> any particular point you'd like to discuss ?
10:23 < kbingham> morimoto, Was it confirmed that the calculation in procedure 1-7 does not calculate any extra overlap? (I.e. my assumption is that it *just* converts a position)
10:23 < kbingham> In otherwords, that this 'undocumented' margin must be added.
10:25 < kbingham> pinchartl, does a 2 pixel overlap sound right for the UDS requiremnts?
10:25 < kbingham> It sounds small to me - considering the SHP has a much larger set of taps...
10:25 < pinchartl> two pixels in total, including both the margin and the 1-7 procedure ?
10:27 < pinchartl> that's a 5 taps filter
10:27 < pinchartl> possibly a bit small, but not uncommon
10:27 < pinchartl> I think
10:27 < kbingham> today's mail from the HW engineer (via morimoto) states: "When I created the code, there was no guide/information, I used (unofficial) attached file's formula. It calculates to be overlap will be over 2pixel"
10:28 < pinchartl> doesn't the overlap depend on the scaling factor in your code ?
10:28 < kbingham> Yes.
10:30 < pinchartl> let's wait and see if we receive more information by e-mail
10:30 < pinchartl> I think you should also use a horizontal gradient and see if it scales correctly
10:30 < pinchartl> instead of the existing test image
10:30 < kbingham> yes, we discussed this before. I'll update the test image
10:31 < kbingham> Ok - well that's me for now I think
10:31 < pinchartl> I think that's it for today
10:31 < pinchartl> I propose adjourning this meeting
10:31 < pinchartl> does anyone second ?
10:32 < kbingham> oh go on then
10:32 < jmondi> fine with me
10:32 < pinchartl> meeting adjourned
10:33 < pinchartl> thank you all for attending
|