summaryrefslogtreecommitdiff
path: root/shared/i915_dma.c
blob: 80f643cd33de781fe00120a383ebefc1c4e8e2a5 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
/* i915_dma.c -- DMA support for the I915 -*- linux-c -*-
 */
/**************************************************************************
 * 
 * Copyright 2003 Tungsten Graphics, Inc., Cedar Park, Texas.
 * All Rights Reserved.
 * 
 **************************************************************************/

#define __NO_VERSION__
#include "i915.h"
#include "drmP.h"
#include "drm.h"
#include "i915_drm.h"
#include "i915_drv.h"


static void i915_print_status_page(drm_device_t *dev)
{
      	drm_i915_private_t *dev_priv = dev->dev_private;
	u32 *temp = dev_priv->hw_status_page;

	if (!temp) {
		DRM_DEBUG("no status page\n");
		return;
	}

   	DRM_DEBUG(  "hw_status: Interrupt Status : %x\n", temp[0]);
   	DRM_DEBUG(  "hw_status: LpRing Head ptr : %x\n", temp[1]);
   	DRM_DEBUG(  "hw_status: IRing Head ptr : %x\n", temp[2]);
      	DRM_DEBUG(  "hw_status: Reserved : %x\n", temp[3]);
   	DRM_DEBUG(  "hw_status: Driver Counter : %d\n", temp[5]);

}




/* Really want an OS-independent resettable timer.  Would like to have
 * this loop run for (eg) 3 sec, but have the timer reset every time
 * the head pointer changes, so that EBUSY only happens if the ring
 * actually stalls for (eg) 3 seconds.
 */
int i915_wait_ring( drm_device_t *dev, int n, const char *caller )
{
   	drm_i915_private_t *dev_priv = dev->dev_private;
   	drm_i915_ring_buffer_t *ring = &(dev_priv->ring);
	u32 last_head = I915_READ(LP_RING + RING_HEAD) & HEAD_ADDR;
	int i;

	for ( i = 0 ; i < 10000 ; i++ ) {
		ring->head = I915_READ(LP_RING + RING_HEAD) & HEAD_ADDR;
	   	ring->space = ring->head - (ring->tail+8);
		if (ring->space < 0) ring->space += ring->Size;
		if ( ring->space >= n )
			return 0;
		
		dev_priv->sarea_priv->perf_boxes |= I915_BOX_WAIT;

		if (ring->head != last_head) 
			i = 0;

		last_head = ring->head;
	}

	return DRM_ERR(EBUSY);
}

void i915_kernel_lost_context(drm_device_t *dev)
{
      	drm_i915_private_t *dev_priv = dev->dev_private;
   	drm_i915_ring_buffer_t *ring = &(dev_priv->ring);
      
   	ring->head = I915_READ(LP_RING + RING_HEAD) & HEAD_ADDR;
     	ring->tail = I915_READ(LP_RING + RING_TAIL) & TAIL_ADDR;
     	ring->space = ring->head - (ring->tail+8);
     	if (ring->space < 0) ring->space += ring->Size;

	if (ring->head == ring->tail)
		dev_priv->sarea_priv->perf_boxes |= I915_BOX_RING_EMPTY;
}


int i915_cleanup(drm_device_t *dev)
{
	/* Make sure interrupts are disabled here because the uninstall ioctl
	 * may not have been called from userspace and after dev_private
	 * is freed, it's too late.
	 */
	if (dev->irq) DRM(irq_uninstall)(dev);

	if (dev->dev_private) {
	   	drm_i915_private_t *dev_priv = 
	     		(drm_i915_private_t *) dev->dev_private;
	   
	   	if (dev_priv->ring.virtual_start) {
		   	DRM_IOREMAPFREE( &dev_priv->ring.map, dev);
		}

	   	if (dev_priv->hw_status_page) {
			pci_free_consistent(dev->pdev, PAGE_SIZE,
				      dev_priv->hw_status_page,
				      dev_priv->dma_status_page);
		   	/* Need to rewrite hardware status page */
		   	I915_WRITE(0x02080, 0x1ffff000);
		}

	   	DRM(free)(dev->dev_private, sizeof(drm_i915_private_t), 
			 DRM_MEM_DRIVER);

	   	dev->dev_private = NULL;
	}

   	return 0;
}



static int i915_initialize(drm_device_t *dev, 
			       drm_i915_private_t *dev_priv,
			       drm_i915_init_t *init)
{
   	memset(dev_priv, 0, sizeof(drm_i915_private_t));

	DRM_GETSAREA();
	if(!dev_priv->sarea) {
		DRM_ERROR("can not find sarea!\n");
		dev->dev_private = (void *)dev_priv;
		i915_cleanup(dev);
		return DRM_ERR(EINVAL);
	}

	DRM_FIND_MAP( dev_priv->mmio_map, init->mmio_offset );
	if(!dev_priv->mmio_map) {
		dev->dev_private = (void *)dev_priv;
		i915_cleanup(dev);
		DRM_ERROR("can not find mmio map!\n");
		return DRM_ERR(EINVAL);
	}

	dev_priv->sarea_priv = (drm_i915_sarea_t *)
		((u8 *)dev_priv->sarea->handle +
		 init->sarea_priv_offset);

   	dev_priv->ring.Start = init->ring_start;
   	dev_priv->ring.End = init->ring_end;
   	dev_priv->ring.Size = init->ring_size;
   	dev_priv->ring.tail_mask = dev_priv->ring.Size - 1;
		
	dev_priv->ring.map.offset = init->ring_start;
	dev_priv->ring.map.size = init->ring_size;
	dev_priv->ring.map.type = 0;
	dev_priv->ring.map.flags = 0;
	dev_priv->ring.map.mtrr = 0;

	DRM_IOREMAP( &dev_priv->ring.map, dev );

   	if (dev_priv->ring.map.handle == NULL) {
		dev->dev_private = (void *) dev_priv;
	   	i915_cleanup(dev);
	   	DRM_ERROR("can not ioremap virtual address for"
			  " ring buffer\n");
	   	return DRM_ERR(ENOMEM);
	}

   	dev_priv->ring.virtual_start = dev_priv->ring.map.handle;
   
	dev_priv->back_offset = init->back_offset;
	dev_priv->front_offset = init->front_offset;
	dev_priv->current_page = 0;
	dev_priv->sarea_priv->pf_current_page = dev_priv->current_page;

	/* We are using separate values as placeholders for mechanisms for
	 * private backbuffer/depthbuffer usage.
	 */
	dev_priv->use_mi_batchbuffer_start = 0;

	/* Allow hardware batchbuffers unless told otherwise.
	 */
	dev_priv->allow_batchbuffer = 1;

   	/* Program Hardware Status Page */
   	dev_priv->hw_status_page =
		pci_alloc_consistent( dev->pdev, PAGE_SIZE, 
						&dev_priv->dma_status_page );

   	if (!dev_priv->hw_status_page) {
		dev->dev_private = (void *)dev_priv;
		i915_cleanup(dev);
		DRM_ERROR("Can not allocate hardware status page\n");
		return DRM_ERR(ENOMEM);
	}
   	memset(dev_priv->hw_status_page, 0, PAGE_SIZE);
	DRM_DEBUG("hw status page @ %p\n", dev_priv->hw_status_page);
   
   	I915_WRITE(0x02080, dev_priv->dma_status_page);
	DRM_DEBUG("Enabled hardware status page\n");
   
	dev->dev_private = (void *)dev_priv;

   	return 0;
}


static int i915_resume(drm_device_t *dev)
{
	drm_i915_private_t *dev_priv = 
		(drm_i915_private_t *) dev->dev_private;

	DRM_DEBUG( "%s\n", __FUNCTION__);
		   
	if(!dev_priv->sarea) {
		DRM_ERROR("can not find sarea!\n");
		return DRM_ERR(EINVAL);
	}

	if(!dev_priv->mmio_map) {
		DRM_ERROR("can not find mmio map!\n");
		return DRM_ERR(EINVAL);
	}

   	if (dev_priv->ring.map.handle == NULL) {
	   	DRM_ERROR("can not ioremap virtual address for"
			  " ring buffer\n");
	   	return DRM_ERR(ENOMEM);
	}

   	/* Program Hardware Status Page */
   	if (!dev_priv->hw_status_page) {
		DRM_ERROR("Can not find hardware status page\n");
		return DRM_ERR(EINVAL);
	}
	DRM_DEBUG("hw status page @ %p\n", dev_priv->hw_status_page);
   
   	I915_WRITE(0x02080, dev_priv->dma_status_page);
	DRM_DEBUG("Enabled hardware status page\n");

   	return 0;
}


int i915_dma_init( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;
   	drm_i915_private_t *dev_priv;
   	drm_i915_init_t init;
   	int retcode = 0;
	
  	DRM_COPY_FROM_USER_IOCTL( init, (drm_i915_init_t *)data, sizeof(init));
	
   	switch(init.func) {
	 	case I915_INIT_DMA:
			dev_priv = DRM(alloc)(sizeof(drm_i915_private_t), 
					      DRM_MEM_DRIVER);
	   		if(dev_priv == NULL) 
				return DRM_ERR(ENOMEM);
	   		retcode = i915_initialize(dev, dev_priv, &init);
	   	break;
	 	case I915_CLEANUP_DMA:
	   		retcode = i915_cleanup(dev);
	   	break;
		case I915_RESUME_DMA:
			retcode = i915_resume(dev);
	   	break;
	 	default:
	   		retcode = -EINVAL;
	   	break;
	}
   
   	return retcode;
}



/* Implement basically the same security restrictions as hardware does
 * for MI_BATCH_NON_SECURE.  These can be made stricter at any time.
 *
 * Most of the calculations below involve calculating the size of a
 * particular instruction.  It's important to get the size right as
 * that tells us where the next instruction to check is.  Any illegal
 * instruction detected will be given a size of zero, which is a
 * signal to abort the rest of the buffer.
 */
static int do_validate_cmd( int cmd )
{
	switch (((cmd>>29) & 0x7)) {
	case 0x0:
		switch ((cmd>>23) & 0x3f) {
		case 0x0: 
			return 1; /* MI_NOOP */
		case 0x4: 
			return 1; /* MI_FLUSH */
		default: 
			return 0; /* disallow everything else */
		}
		break;
	case 0x1: 
		return 0;	/* reserved */
	case 0x2: 
		return (cmd & 0xff) + 2; /* 2d commands */
	case 0x3:
		if (((cmd>>24) & 0x1f) <= 0x18)
			return 1;

		switch ((cmd>>24) & 0x1f) {
		case 0x1c: 
			return 1;
		case 0x1d:
			return (cmd & 0xffff) + 2;
		case 0x1e: 
			if (cmd & (1<<23)) 
				return (cmd & 0xffff) + 1;
			else
				return 1;
		case 0x1f:
			if ((cmd & (1<<23)) == 0) /* inline vertices */
				return (cmd & 0x1ffff) + 2;
			else if (cmd & (1<<17)) /* indirect random */
				if ((cmd & 0xffff) == 0)
					return 0; /* unknown length, too hard */
				else
					return (((cmd & 0xffff) + 1) / 2) + 1;
			else
				return 2; /* indirect sequential */
		default: 
			return 0;
		}
	default:
		return 0;
	}

	return 0;
}

static int validate_cmd( int cmd )
{
	int ret = do_validate_cmd( cmd );
	
/* 	printk("validate_cmd( %x ): %d\n", cmd, ret); */

	return ret;
}
	
	

static int i915_emit_cmds( drm_device_t *dev,
			   int *buffer,
			   int dwords )
{
   	drm_i915_private_t *dev_priv = dev->dev_private;
	int i;
	RING_LOCALS;

	for (i = 0 ; i < dwords ; ) {
		int cmd, sz;

		if (DRM_COPY_FROM_USER_UNCHECKED(&cmd, &buffer[i], sizeof(cmd)))
			return DRM_ERR( EINVAL );

/* 		printk("%d/%d ", i, dwords); */

		if ((sz = validate_cmd(cmd)) == 0 || i + sz > dwords) 
			return DRM_ERR( EINVAL );

		BEGIN_LP_RING( sz );
		OUT_RING(cmd);

		while (++i, --sz) {
			if (DRM_COPY_FROM_USER_UNCHECKED( &cmd, &buffer[i], 
							  sizeof(cmd))) {
				return DRM_ERR( EINVAL );
			}
			OUT_RING(cmd);
		}
		ADVANCE_LP_RING();
	}

	return 0;
}

static int i915_emit_box( drm_device_t *dev,
			  drm_clip_rect_t *boxes,
			  int i,
			  int DR1,
			  int DR4)
{
   	drm_i915_private_t *dev_priv = dev->dev_private;
   	drm_clip_rect_t box;
   	RING_LOCALS;

	if (DRM_COPY_FROM_USER_UNCHECKED( &box, &boxes[i], sizeof(box) )) {
		return EFAULT;
	}

	if (box.y2 <= box.y1 ||
	    box.x2 <= box.x1 ||
	    box.y2 <= 0 ||
	    box.x2 <= 0) {
		DRM_ERROR("Bad box %d,%d..%d,%d\n",
			  box.x1, box.y1, box.x2, box.y2);
		return DRM_ERR(EINVAL);
	}
				

	BEGIN_LP_RING(6);
	OUT_RING( GFX_OP_DRAWRECT_INFO );
	OUT_RING( DR1 );
	OUT_RING( (box.x1 & 0xffff) | (box.y1<<16) );
	OUT_RING( ((box.x2-1) & 0xffff) | ((box.y2-1)<<16) );
	OUT_RING( DR4 );
	OUT_RING( 0 );
	ADVANCE_LP_RING();
	
	return 0;
}


static int i915_dispatch_cmdbuffer(drm_device_t *dev, 
				   drm_i915_cmdbuffer_t *cmd )
{
   	drm_i915_private_t *dev_priv = dev->dev_private;
   	int nbox = cmd->num_cliprects;
	int i = 0, count, ret;
   	RING_LOCALS;

	if (cmd->sz & 0x3) {
		DRM_ERROR("alignment");
		return DRM_ERR(EINVAL);
	}
		
   	i915_kernel_lost_context(dev);

	count = nbox ? nbox : 1;

	for (i = 0 ; i < count ; i++) {
		if (i < nbox) {
			ret = i915_emit_box( dev, cmd->cliprects, i, 
					     cmd->DR1, cmd->DR4);
			if (ret) 
				return ret;
		}

		ret = i915_emit_cmds( dev, (int *)cmd->buf, cmd->sz / 4 );
		if (ret) 
			return ret;
	}

	return 0;
}




static int i915_dispatch_batchbuffer(drm_device_t *dev, 
				    drm_i915_batchbuffer_t *batch )
{
   	drm_i915_private_t *dev_priv = dev->dev_private;
   	drm_clip_rect_t box, *boxes = batch->cliprects;
   	int nbox = batch->num_cliprects;
	int i = 0, count;
   	RING_LOCALS;

	if ((batch->start | batch->used) & 0x7) {
		DRM_ERROR("alignment");
		return DRM_ERR(EINVAL);
	}
		
   	i915_kernel_lost_context(dev);

	count = nbox ? nbox : 1;

	for (i = 0 ; i < count ; i++) {
		if (i < nbox) {
			int ret = i915_emit_box( dev, boxes, i,
						 batch->DR1, batch->DR4);
			if (ret) 
				return ret;
		}

		if (dev_priv->use_mi_batchbuffer_start) {
			BEGIN_LP_RING(2);
			OUT_RING( MI_BATCH_BUFFER_START | (2<<6) );
			OUT_RING( batch->start | MI_BATCH_NON_SECURE );
			ADVANCE_LP_RING();
		} 
		else {
			BEGIN_LP_RING(4);
			OUT_RING( MI_BATCH_BUFFER );
			OUT_RING( batch->start | MI_BATCH_NON_SECURE );
			OUT_RING( batch->start + batch->used - 4 );
			OUT_RING( 0 );
			ADVANCE_LP_RING();
		}
	}

	
	dev_priv->sarea_priv->last_enqueue = dev_priv->counter++;

	BEGIN_LP_RING(4);
	OUT_RING( CMD_STORE_DWORD_IDX );
	OUT_RING( 20 );
	OUT_RING( dev_priv->counter );
	OUT_RING( 0 );
	ADVANCE_LP_RING();

	return 0;
}

static int i915_dispatch_flip( drm_device_t *dev )
{
   	drm_i915_private_t *dev_priv = dev->dev_private;
	RING_LOCALS;

	DRM_DEBUG( "%s: page=%d pfCurrentPage=%d\n", 
		   __FUNCTION__, 
		   dev_priv->current_page,
		   dev_priv->sarea_priv->pf_current_page);

  	i915_kernel_lost_context(dev);


	BEGIN_LP_RING( 2 );
    	OUT_RING( INST_PARSER_CLIENT | INST_OP_FLUSH | INST_FLUSH_MAP_CACHE ); 
	OUT_RING( 0 );
	ADVANCE_LP_RING();

	BEGIN_LP_RING( 6 );
	OUT_RING( CMD_OP_DISPLAYBUFFER_INFO | ASYNC_FLIP );	
	OUT_RING( 0 );
	if ( dev_priv->current_page == 0 ) {
		OUT_RING( dev_priv->back_offset );
		dev_priv->current_page = 1;
	} else {
		OUT_RING( dev_priv->front_offset );
		dev_priv->current_page = 0;
	}
	OUT_RING(0);
	ADVANCE_LP_RING();


	BEGIN_LP_RING( 2 );
	OUT_RING( MI_WAIT_FOR_EVENT |
		  MI_WAIT_FOR_PLANE_A_FLIP );
	OUT_RING( 0 );
	ADVANCE_LP_RING();
	

	dev_priv->sarea_priv->last_enqueue = dev_priv->counter++;

	BEGIN_LP_RING(4);
	OUT_RING( CMD_STORE_DWORD_IDX );
	OUT_RING( 20 );
	OUT_RING( dev_priv->counter );
	OUT_RING( 0 );
	ADVANCE_LP_RING();

	dev_priv->sarea_priv->pf_current_page = dev_priv->current_page;
	return 0;
}


static int i915_quiescent(drm_device_t *dev)
{
   	drm_i915_private_t *dev_priv = dev->dev_private;

  	i915_kernel_lost_context(dev);
	return i915_wait_ring( dev, dev_priv->ring.Size - 8, __FUNCTION__ );
}


int i915_flush_ioctl( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;

   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
		DRM_ERROR("i915_flush_ioctl called without lock held\n");
		return DRM_ERR(EINVAL);
	}

    	return i915_quiescent(dev); 
}

int i915_batchbuffer( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;
   	drm_i915_private_t *dev_priv = (drm_i915_private_t *)dev->dev_private;
      	u32 *hw_status = dev_priv->hw_status_page;
   	drm_i915_sarea_t *sarea_priv = (drm_i915_sarea_t *) 
     					dev_priv->sarea_priv; 
	drm_i915_batchbuffer_t batch;
	int ret;

	if (!dev_priv->allow_batchbuffer) {
		DRM_ERROR("Batchbuffer ioctl disabled\n");
		return DRM_ERR(EINVAL);
	}

	DRM_COPY_FROM_USER_IOCTL( batch, (drm_i915_batchbuffer_t *)data, 
				  sizeof(batch) );

	DRM_DEBUG("i915 batchbuffer, start %x used %d cliprects %d\n",
		  batch.start, batch.used, batch.num_cliprects);


   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
		DRM_ERROR("i915_batchbuffer called without lock held\n");
		return DRM_ERR(EINVAL);
	}

	if (batch.num_cliprects && DRM_VERIFYAREA_READ(batch.cliprects, 
						       batch.num_cliprects *
						       sizeof(drm_clip_rect_t)))
		return DRM_ERR(EFAULT);

	ret = i915_dispatch_batchbuffer( dev, &batch );

   	sarea_priv->last_dispatch = (int) hw_status[5];   
	return ret;
}

int i915_cmdbuffer( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;
   	drm_i915_private_t *dev_priv = (drm_i915_private_t *)dev->dev_private;
      	u32 *hw_status = dev_priv->hw_status_page;
   	drm_i915_sarea_t *sarea_priv = (drm_i915_sarea_t *) 
		dev_priv->sarea_priv; 
	drm_i915_cmdbuffer_t cmdbuf;
	int ret;

	DRM_COPY_FROM_USER_IOCTL( cmdbuf, (drm_i915_cmdbuffer_t *)data, 
				  sizeof(cmdbuf) );

	DRM_DEBUG("i915 cmdbuffer, buf %p sz %d cliprects %d\n",
		  cmdbuf.buf, cmdbuf.sz, cmdbuf.num_cliprects);


   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
		DRM_ERROR("i915_cmdbuffer called without lock held\n");
		return DRM_ERR(EINVAL);
	}

	if (cmdbuf.num_cliprects && 
	    DRM_VERIFYAREA_READ(cmdbuf.cliprects, 
				cmdbuf.num_cliprects *
				sizeof(drm_clip_rect_t))) {
		DRM_ERROR("Fault accessing cliprects\n");
		return DRM_ERR(EFAULT);
	}

	ret = i915_dispatch_cmdbuffer( dev, &cmdbuf );
	if (ret) {
		DRM_ERROR("i915_dispatch_cmdbuffer failed\n");
		return ret;
	}

   	sarea_priv->last_dispatch = (int) hw_status[5];   
	return 0;
}



int i915_do_cleanup_pageflip( drm_device_t *dev )
{
	drm_i915_private_t *dev_priv = dev->dev_private;

	DRM_DEBUG("%s\n", __FUNCTION__);
	if (dev_priv->current_page != 0)
		i915_dispatch_flip( dev );

	return 0;
}

int i915_flip_bufs( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;

	DRM_DEBUG("%s\n", __FUNCTION__);
   	if(!_DRM_LOCK_IS_HELD(dev->lock.hw_lock->lock)) {
		DRM_ERROR("i915_flip_buf called without lock held\n");
		return DRM_ERR(EINVAL);
	}

	return i915_dispatch_flip( dev );
}



int i915_getparam( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;
	drm_i915_private_t *dev_priv = dev->dev_private;
	drm_i915_getparam_t param;
	int value;

	if ( !dev_priv ) {
		DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
		return DRM_ERR(EINVAL);
	}

	DRM_COPY_FROM_USER_IOCTL(param, (drm_i915_getparam_t *)data, 
				 sizeof(param));

	switch( param.param ) {
	case I915_PARAM_IRQ_ACTIVE:
		value = dev->irq ? 1 : 0;
		break;
	case I915_PARAM_ALLOW_BATCHBUFFER:
		value = dev_priv->allow_batchbuffer ? 1 : 0;
		break;
	default:
		DRM_ERROR("Unkown parameter %d\n", param.param);
		return DRM_ERR(EINVAL);
	}

	if ( DRM_COPY_TO_USER( param.value, &value, sizeof(int) ) ) {
		DRM_ERROR("DRM_COPY_TO_USER failed\n");
		return DRM_ERR(EFAULT);
	}
	
	return 0;
}


int i915_setparam( DRM_IOCTL_ARGS )
{
	DRM_DEVICE;
	drm_i915_private_t *dev_priv = dev->dev_private;
	drm_i915_setparam_t param;

	if ( !dev_priv ) {
		DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
		return DRM_ERR(EINVAL);
	}

	DRM_COPY_FROM_USER_IOCTL( param, (drm_i915_setparam_t *)data, 
				  sizeof(param) );

	switch( param.param ) {
	case I915_SETPARAM_USE_MI_BATCHBUFFER_START:
		dev_priv->use_mi_batchbuffer_start = param.value;
		break;
	case I915_SETPARAM_TEX_LRU_LOG_GRANULARITY:
		dev_priv->tex_lru_log_granularity = param.value;
		break;
	case I915_SETPARAM_ALLOW_BATCHBUFFER:
		dev_priv->allow_batchbuffer = param.value;
		break;
	default:
		DRM_ERROR("unknown parameter %d\n", param.param);
		return DRM_ERR(EINVAL);
	}


	return 0;
}