Age | Commit message (Collapse) | Author |
|
as Rusty points out MUST assume is not very good requirement.
clarify it.
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@312 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@311 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Doesn't look any different, but consistent.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@310 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
And use the ellipsis package, which makes it symmetrical.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@309 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
1) make it clear that queue_enable is 0 on reset.
2) device MUST present a VIRTIO_PCI_CAP_DEVICE_CFG if needed for type.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@308 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
"it" could refer to failed bit or the driver.
clarify.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@307 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
VIRTIO-70
Cc: Patrick Durusau <patrick@durusau.net>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@304 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
VIRTIO-64
Cc: Patrick Durusau <patrick@durusau.net
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@303 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
weaken hacky requirements helpful for graceful failure
for non transitional PCI devices from MUST to SHOULD.
It's nice to have but it's not like it makes things work, and you
can avoid trouble simply by using the most recent drivers.
also move them out to a separate section
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@301 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@299 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@298 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@297 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@296 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@295 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@294 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@293 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
TODO: we really should be more specific
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@292 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@291 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
legacy has no generation field.
add SHOULD statement to document multi-byte field
access rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@290 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
this is a non normative section.
we merely mention that details are given
for each device.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@289 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@288 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Two issues with the comment:
- it mixes legacy documentation in main part of the spec
- it says what format *isn't* - instead of what it *is*
Now that we have documented that LE can mean
legacy endian, there's no need for the comment.
Resolves issues:
VIRTIO-58
Change accepted on VIRTIO TC Meeting, 3 December 2013
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@287 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Holm Rauchfuss <holm.rauchfuss@huawei.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@286 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Minor fix: add explicit reference to QueueNumMax in the
normative paragraph describing QueueNum.
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@285 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Minor fix: commit 238 wrapped register names in \field{}s
and modified one of the register table macros, but missed
the other one.
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@284 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Minor fix: the size of 0x100 was obviously wrong,
as it didn't allow for configuration space.
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@283 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
We currently mandate that the driver clears the summary indicator
before processing the queue indicator; this is bogus, as the requirement
for interrupt avoidance is rather that the driver unsets the summary
indicator before before it stops looking at the queue indicator.
In fact, the best way to get a race-free implementation of the interrupt
handler is to process the queue indicators twice; let's add a recommondation
to do that.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> (merged)
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@281 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Just add a reserved ID for Timer/Clock device. There is no work
on it yet but it is nice to have the ID which could be used safely
in preliminary implementations.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@280 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@279 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@277 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
This could use some more rigour, I think: there are still many
implied requirements which could be called out.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@276 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@275 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@274 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@273 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@272 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
The section on initialization is now non-normative.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@271 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Rather than treat selectors 0 and 1 as special, the wording for features
is made more general (though still the same effect).
I split the interrupt handler into a separate subsection: it was
misleading because it didn't handle configuration interrupts until
the next section. It's also non-normative.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@270 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
The big change here is in introducing new subsections for interrupt and notification
suppression, and moving all requirements into them.
The example processing loop is also moved into a note, to show clearly
that it's not normative.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@269 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Virtqueues / Message Framing
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@268 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@267 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Split text into descriptive and normative.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@266 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
From http://docs.oasis-open.org/templates/TCHandbook/ConformanceGuidelines.html:
Normative statements MUST be referenceable so that a statement may be
referenced from another part of a specification, but more importantly
so they can be referenced from Conformance Clauses.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@265 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Start with explanation, progress to normative requirements.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@264 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@263 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
This requirement applies to any system which *did* have legacy drivers.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@262 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
It's non-normative.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@259 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Haven't marked them non-normative yet, but it makes sense to put the header
in an appendix.
Reported-by: Patrick Durusau <patrick@durusau.net>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@258 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Reported-by: Patrick Durusau <patrick@durusau.net>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@257 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Reported-by: Patrick Durusau <patrick@durusau.net>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@256 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Feedback:
10) 4.1.3.1.2 Queue Vector Configuration
Some of the information from section 8.4 needs to be moved to
here, for example that the device may have an MSI-X table size
other than 2048.
Otherwise, this reads as though the MSI-X table must always have
2048 entries.
11) Please explicitly describe the device behavior when writing
a vector value beyond the MSI-X table size.
Address these comments.
Cc: Arun Subbarao <asubbarao@lnxw.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@255 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|