summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-02-10patch feedback-7-orig.patchrusty
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@217 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10patch feedback-6.patchrusty
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@216 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10patch feedback-5.patchrusty
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@215 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10patch feedback-4.patchrusty
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@214 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10PCI Section Reworkrusty
1) Minor changes from must to MUST etc. 2) More references using \ref. 3) Move section on capabilities first, before we talk about the common config layout. The previous order made sense for legacy. 4) Make explicit subsections for each type of capability and move more information into them. 5) Make it clear that there must be one or more. 6) Include 'struct virtio_pci_cap cap;' in struct virtio_pci_cfg_cap to match virtio_pci_notify_cap. 7) Explicitly note there's no way to negotiate the queue size for a legacy device. 8) Fix old language on config change event: config is not in the pci configuration space. 9) Explicitly state what the driver should do to use virtio_pci_cfg_cap. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@213 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10C struct specifications.rusty
Explicitly specify that our C struct specifications are without padding, and add some definitions for our integer data types. [ Rusty - added /* comments */ and removed redundant old le* explanation ] Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@212 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10Feedback: more clarity on aim of ring layout & cache effects.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@211 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10Feedback: more introduction reworking from MST.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@210 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-10ccw: missed field conversionsrusty
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@209 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-09More feedback updates from Thomas.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@208 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-07Cleanup and setup clarificationsrusty
1) Explicitly allow drivers to read config space during feature negotiation. 2) Add the concept of a "live" virtqueue, and explicitly disallow moving it backwards or changing descriptors. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@207 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-07More feedback (partial)rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@206 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-07More feedback from Thomas.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@205 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-07block: legacy SCSI command fix.rusty
When describing the historical layout requirements, it says "status field is a separate read-only buffer of size 1 byte, by itself." That's clearly wrong, as it says above "The final status byte is written by the device" Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@204 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-06whitespace: make all examples unindented, and avoid tabs.rusty
This makes the formatting far nicer. Applying now as it touches almost all examples and layouts, so we can rebase future changes on top of common ground. (Based on feedback from Thomas Huth for one example, and generalized). Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@203 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-02-03More feedback.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@202 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-313.2.1: Language tightening.rusty
1) Lots of "we", replace with "the driver". 2) Use MAY and MUST NOT for spurious notifications. 3) Don't refer to PCI configuration space for notification. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@201 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-31Feedback #4: Haggai Eran's VIRTIO_RING_F_INDIRECT_DESC fix.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@200 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-31Feedback: document decisions in the files.rusty
I also sent out a thankyou mail for these. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@199 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-294.1.2.5: Legacy: PCI Device Layout: fix PCI header fields orderhornet
The order of the fields in the legacy PCI header seems to get messed up in the new spec, with the "Queue Address" moved behind "Queue Notify". According to the 0.9.5 version of the spec it should be: * Device Features 32 * Driver Features 32 * Queue Address 32 * Queue Size 16 * Queue Select 16 * Queue Notify 16 * Device Status 8 * ISR Status 8 Signed-off-by: Pawel Moll <pawel.moll@arm.com> -- 1.8.3.2 git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@198 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-29Feedback #3: Feedback from Pranavkumar Sawargaonkar ↵rusty
(VIRTIO_CONSOLE_F_EMERG_WRITE) Document: virtio-v1.0-csprd01 Number: 3 Date: Tue, 21 Jan 2014 15:09:54 +0530 Link to Mail: https://lists.oasis-open.org/archives/virtio-comment/201401/msg00037.html Commenter name: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> Approved at meeting 2014-01-28: https://lists.oasis-open.org/archives/virtio/201401/msg00054.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@197 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-29Feedback #2: More feedback from Thomas Huthrusty
Document: virtio-v1.0-csprd01 Number: 2 Date: Fri, 10 Jan 2014 13:49:49 +0100 Link to Mail: https://lists.oasis-open.org/archives/virtio-comment/201401/msg00001.html Commenter name: Thomas Huth <thuth@linux.vnet.ibm.com> Approved at meeting 2014-01-28: https://lists.oasis-open.org/archives/virtio/201401/msg00054.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@196 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-29Feedback #1: fixes from Thomas Huthrusty
Document: virtio-v1.0-csprd01 Number: 1 Date: Fri, 10 Jan 2014 11:01:44 +0100 Link to Mail: https://lists.oasis-open.org/archives/virtio-comment/201401/msg00000.html Commenter name: Thomas Huth <thuth@linux.vnet.ibm.com> Approved at meeting: 2014-01-28 https://lists.oasis-open.org/archives/virtio/201401/msg00054.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@195 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-28mmio: Move QueueReady register from offset 0x03c to 0x044hornet
Legacy devices have QueueAlign register at 0x03c. To stay on the safe side and avoid any potential clashes (also to be able to abort any wrong writes), move it to previously unused offset 0x044. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@194 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-23virtio-ccw: fix set_revision payload definitioncornelia.huck
The members of struct virtio_rev_info are big endian: use be16 types. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@193 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-23More feedback.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@192 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-23Formatting: fix feature bits for console device.rusty
Make them a description list like every other device. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@191 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-23Michael's patch adding MQ support added some u16s; they are u16 inrusty
legacy mode but should be le16 for modern devices. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@190 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-21Split feedback into multiple files.rusty
Makes it easier to edit/apply individual proposals. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@189 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-21feedback.txt: updaterusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@188 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-20html: make footnotes inlinemstsirkin
Makes text search easier and reduces clutter in the public directory. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@187 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-17Feedback file for virtio-comment.rusty
Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@186 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-17net/multiqueue: tighten wordingrusty
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@185 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-17Fixes for first WD front page.rusty
Based on feedback from Paul Knight <paul.knight@oasis-open.org>. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@184 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-12html: Convert ligatures into normal ASCII charactermstsirkin
Seems to work for me, although I don't know exactly why (I have a feeling, but no proof ;-) Signed-off-by: Pawel Moll <pawel.moll@arm.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@183 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-12makehtml.sh: drop workaround, add warningmstsirkin
Issues in html generation turn out to be due to tex4ht being unable to find fonts due to misconfigured font paths. As we are unable to work-around them properly anyway replace work-around with a warning and print suggestions for fixing the config. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@182 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-12README: note on issues and work-aroundsmstsirkin
Document that makehtml needs to be edited to use workaround. Document that paths need to be adjusted if copying config from an old installation. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@181 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-12.exrc: rename to _vimrcmstsirkin
.exrc is not allowed in the OASIS Library, since "dot" files are special files in file system. They are specifically disallowed by the Naming Directives [1] : "Filenames and directory names must neither begin nor end with a punctuation character (period or hyphen). [...]" Rename to _vimrc which also works - from vim help: d. If the 'exrc' option is on (which is not the default), the current directory is searched for three files. The first that exists is used, the others are ignored. - The file ".vimrc" (for Unix, Amiga and OS/2) (*) "_vimrc" (for MS-DOS and Win32) (*) - The file "_vimrc" (for Unix, Amiga and OS/2) (*) ".vimrc" (for MS-DOS and Win32) (*) - The file ".exrc" (for Unix, Amiga and OS/2) "_exrc" (for MS-DOS and Win32) Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@180 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-01-03mmio: Obviously wrong notification register namehornet
The "4.2.3.3 Notifying The Device" section said "writing the index of the updated queue to the QueueNum". This is obviously wrong - should read "QueueNotify". Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@179 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-16title & acknowledgements: Make ARM less limitedhornet
... by removing the "Limited" bit of the name. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@178 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-162.3.2 MMIO: Configuration space offset correctedhornet
The offset in the MMIO configuration space description (table 4.1) became wrong at some time (0x0fff). Fixed. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@177 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-122.3.2 MMIO: Notifications & interrupts clarificationshornet
(Hopefully) clarified the way notifications are being passed between the device and the driver and about the meaning of the interrupt registers. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@176 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-121. Introduction: Removed left-over "PCI"hornet
The "Extensible" paragraph of the introduction still referred to "Virtio PCI devices". Changed to "Virtio devices". Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@175 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-122.3.2 MMIO: Further clarificationshornet
Clarified driver behaviour for out-of-spec MagicValue, Version and DeviceID values. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@174 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-12ccw: feature bit endiannesscornelia.huck
In contrast to the other values transmitted in ccw payload, feature bits are little endian. Fix it in the structure definition. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@173 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-12ccw: clarify passing of subchannel idcornelia.huck
Make clear that the upper half of the register must be ignored, just like normal I/O instructions do. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@172 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-12ccw: Tighten specification language.cornelia.huck
must -> MUST changes, removed inappropriate mays. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@171 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-092.3.2 MMIO: LaTeXisationhornet
Converter the register layout descriptions into tables. Also hardened the specification language, using MUSTs and MUST NOTs. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@170 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-08virtio-html: add right and left borders for tablesmstsirkin
In html version our tables lack vertical separators, that's ugly. Tweak config file for htlatex to add these. htlatex wants to use hr for horizontal separation (presumably for portability?) So add only vertical borders using CSS. Note: pdf version has a dual line after 1st column in each row, I didn't figure out how to make this with htlatex yet. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@169 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2013-12-08commands-pdf.tex: align title pagemstsirkin
Section titles are currently misaligned on the title page. This patch aligns them back. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@168 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 07:01:08 +0000