summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-08-05VIRTIO-110: ARM's feedback for MMIO chapter, trivial changeshornet
Those changes do not add nor remove any features and constitutes only error correction and editorial changes. * Typos and language mistakes in 4.2, 4.2.1, 4.2.2 and 4.2.2.2. * Extra clarifications for InterruptACK. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@415 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-08-04legacy: grammar fixupmstsirkin
Legacy devices are "they" not "it". VIRTIO-113 Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@414 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-08-04legacy: consistently use past tensemstsirkin
Paragraph with general description of feature negotiation for legacy devices mixed present and past tense. As rest of legacy sections all use past tense, fix the only instance of the present tense: s/do/did/ for consistency. It might be argued that legacy devices still have these properties so present tense is more appropriate, on the other hand, using the past tense helps stress the fact that current spec does not attempt to fully describe the legacy device/driver behaviour: this text is only here to serve as motivation for the transitional device/driver requirements. VIRTIO-112 Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@413 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-30VIRTIO-111: Fix minor typosmstsirkin
Fix minor typos as reported in ARM's feedback. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@412 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-30REVISION: update for csprd03mstsirkin
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@411 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-30REVISION: update for csd03mstsirkin
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@410 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-30Revert "VIRTIO-111: Fix minor typos"mstsirkin
This reverts commit 8a3d1521930d9dacca4972d591ff720d614e37e8. Was not in CSD03, will re-apply immediately after updating REVISION. git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@409 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-30suppress diff for list of chairsmstsirkin
output looks ugly, and this isn't of interest for reviewers git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@408 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-30title page fixes for csd03mstsirkin
Address comments by Paul Knight: - list Rusty as an editor as well - add MST as co-chair git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@407 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-07-23VIRTIO-111: Fix minor typoshornet
Fix minor typos as reported in ARM's feedback. Signed-off-by: Pawel Moll <pawel.moll@arm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@406 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27setup: allow overriding date from environmentmstsirkin
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@405 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27title: update previous version linkmstsirkin
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@404 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27makediffall.sh: script to build all, include diffmstsirkin
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@403 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27makediff: add longtable as floatenvmstsirkin
fix latex error in diff generation Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@402 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27changelog: add two last commitsmstsirkin
Not critical but just for completeness... Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@401 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27getchangelog: add paragraphs when escaping latexmstsirkin
makes change log easier to read. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@400 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27changelog: fill changelog since draft2mstsirkin
This will make review easier. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@399 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27acknowledgements: add draft 3 reviewers, sortmstsirkin
Add new reviewers and sort by name. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@398 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-27add draft2 acknowledgementsmstsirkin
List people that provided comments on draft01 in the acknowledgements section. Might be a nice way to encourage reviews. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@397 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26diff: back to green for added textmstsirkin
using blue does not work well for html Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@396 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26makehtml: fix bad fontpath detectionmstsirkin
Fix wanring when run this shell script. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@395 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26remove fixupdiff scriptmstsirkin
remove fixupdiff.pl, it's unused now Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@394 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26makediff: cleanup using begingroup/endgroupmstsirkin
Pawel Moll found a way to work around xetex bugs without mangling latexdiff output using perl: - define DIFbegin/DIFFend commands in preample - pass --config FLOATENV= to latexdiff Use this in preference to the fixupdiff perl script. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@393 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26script to create html diff as wellmstsirkin
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@392 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26more latexdiff hacksmstsirkin
- change link color from green to pinegreen. Looks better to me. - split footnotes out from their text, so that latexdiff does not consider them as a unit - mark field command as safe for latexdiff, otherwise it's not shown in red - hack adding DIFaddtext within footnotes could not handle case where latexdiff inserted multiple DIFadd within the footnote. Instead, detect when footnote is within DIFaddbegin/DIFdelbegin, add an extra DIFaddbegin/DIFdelbegin within the footnote. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@391 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26diffpreamble: fix colors for links within diffmstsirkin
Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@390 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26work around xetex bugmstsirkin
Too many \color directives produce corrupted output and this warning: WARNING ** Color stack overflow. Just ignore. Use script to reduce # of these directives. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@389 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26diffpreamble: remove duplicate textmstsirkin
latexdiff adds some Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@388 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-26makediffpdf.sh: tool to create marked-up diffmstsirkin
make pdf diff using latexpand and latexdiff-fast styles are set in diffpreamble.tex in diff, links are coloured green instead of blue Must be run within a git-svn clone of the spec repository. Note: latexdiff has --flatten option, this and options to select diff style don't seem to work well. So flatten by script myself, and add our own preamble. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@387 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-25pci: minor fomatting tweakmstsirkin
Make table look better. Drop spaces that make latexdiff stumble. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@386 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-25fixup pci: switch from subsystem id to device idmstsirkin
Patch sent to list (and applied by Rusty in commit fffcbe327c69e510239fff5627034aa2ab4b2d84 pci: switch from subsystem id to device id ) did not actually implement what commit log said it implements. The result is wrong for transitional devices: Adding 0xfff works for for net+block only; for transitional pci devices there is no fixed scheme: ~/projects/qemu/include # grep VIRTIO_ID hw/virtio/*.h hw/virtio/virtio-balloon.h:#define VIRTIO_ID_BALLOON 5 hw/virtio/virtio-blk.h:#define VIRTIO_ID_BLOCK 2 hw/virtio/virtio-net.h:#define VIRTIO_ID_NET 1 hw/virtio/virtio-rng.h:#define VIRTIO_ID_RNG 4 hw/virtio/virtio-scsi.h:#define VIRTIO_ID_SCSI 8 hw/virtio/virtio-serial.h:#define VIRTIO_ID_CONSOLE 3 ~/projects/qemu/include # grep VIRTIO hw/pci/*.h hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_NET 0x1000 hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_BLOCK 0x1001 hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_BALLOON 0x1002 hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_CONSOLE 0x1003 hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_SCSI 0x1004 hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_RNG 0x1005 hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_9P 0x1009 I am guessing TC went by commit log when it approved the change, so fixing it up directly. Cc: Andrew Thornton <andrewth@google.com> Cc: Rusty Russell <rusty@ozlabs.org> Cc: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@385 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-17content.tex: VIRTIO-106: mention possibility of failing TMFspbonzini
This completes the review of virtio-scsi based on observations from Google. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@384 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-16fix erroneous reference to Subsystem Device IDpbonzini
Subsystem device ID only exists for PCI. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@383 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-16small virtio-serial fixrusty
nr_ports does not exist in the spec. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@382 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-09virtio-scsi: support well-known logical unitspbonzini
The REPORT LUNS well-known logical unit is useful because it lets you retrieve information about all targets with a single command. It also provides an easy way to send a no-op request. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@381 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-09consistent formatting of footnotespbonzini
Put the indicator before punctuation, and terminate the footnote with a period. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@380 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-09virtio-scsi: additional SHOULDificationpbonzini
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@379 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-09virtio-scsi: fixes to protection informationpbonzini
pi_bytesin is in the device-readable section. Document lack of residual field. Use le32 instead of u32. This matches the new patch series that Nicholas sent for vhost-scsi. Cc: <nab@daterainc.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@378 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-05PCI: remove duplicate paragraph.rusty
I chose the one which used the full nomenclature. Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@377 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-05pci: switch from subsystem id to device idrusty
Switch virtio pci to use standard device id instead of using the subsystem id. Unfortunately, there's no system to the way KVM allocated device IDs to virtio devices, we'll just have to specify these using a table, and use a new range for future devices. For existing devices this results in two possible IDs that all drivers will need to match. Unfortunate, but the cost is small. As a nice side effect, this allows us to make non-transitional devices use IDs 0x40 and up, this reduces even further the chance that a non transitional device will match legacy drivers. And, it's probably a good idea to allow drivers to match specific subsystem IDs if they want to, so relax requirement for drivers to match all subsystem/vendor ID configurations, but allow them to do so. To avoid confusion, say "PCI Device ID" and "PCI Subsystem ID" everywhere, prefix "PCI" for other standard registers, for consistency. VIRTIO-102 Note: issue reporter suggested 0x10XX where XX is the virtio device ID. This would conflict with legacy devices, which seem to have used 7 IDs in the range 0x1000 to 0x103f without any system. Let's use a new range 0x1040 to 0x107f for non-transitional devices, and add a table documenting the transitional IDs used by in practice. (Approved at 2014-06-04 meeting: https://lists.oasis-open.org/archives/virtio/201406/msg00013.html ) Cc: Andrew Thornton <andrewth@google.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@376 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-06-05pci: set ISR bit on config change with MSI-Xrusty
config changes are slow path anyway, so we can as well set ISR bit to help drivers detect changes. This allows sharing config interrupts which is what issue reporter seems to ask for. VIRTIO-104 (Approved at 2014-06-04 meeting: https://lists.oasis-open.org/archives/virtio/201406/msg00013.html ) Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@375 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-31NEEDS_RESET: trivial clarificationmstsirkin
If device sets NEEDS_RESET before DRIVER_OK, it can't send notifications to driver. Make this clear. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@374 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-22Fix build of documentrusty
Error introduced in 59cd205cea "VIRTIO-98: Add DEVICE_NEEDS_RESET": seems that underscores in labels are verboten: [133] [134] (./virtio-v1.0-csprd02.aux ! Missing \endcsname inserted. <to be read again> \unhbox l.45 ...ts: Device Status Field}}{subsection.1}{}} Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@373 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-22content.tex: virtio-scsi review (VIRTIO-106)rusty
As prompted by Rusty, add a few more MUST/SHOULD items for both devices and drivers. Clarify semantics of max_channel/max_id/max_lun, task_attr and task management functions. (As per minutes of meeting 2014-05-20: https://lists.oasis-open.org/archives/virtio/201405/msg00034.html ) Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@372 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-22content.tex: add support for protection information (VIRTIO-108)rusty
This is a new feature that was suggested by Nicholas Bellinger, who also provided a prototype implementation for vhost-scsi. (As per minutes of meeting 2014-05-20: https://lists.oasis-open.org/archives/virtio/201405/msg00034.html ) Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@371 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-12VIRTIO-96: Assign device id to virtio inputrusty
Assign device id to virtio input As passed at meeting 2014-05-06: https://lists.oasis-open.org/archives/virtio/201405/msg00016.html Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@370 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-12VIRTIO-52: Make mac field read only.rusty
As passed at meeting 2014-05-06: https://lists.oasis-open.org/archives/virtio/201405/msg00016.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@369 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-12VIRTIO-107: Clarify net mac commands.rusty
As passed at meeting 2014-05-06: https://lists.oasis-open.org/archives/virtio/201405/msg00016.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@368 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-12VIRTIO-98: Add DEVICE_NEEDS_RESET.rusty
As passed at meeting 2014-05-06: https://lists.oasis-open.org/archives/virtio/201405/msg00016.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@367 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
2014-05-12VIRTIO-87: limit descriptor chain length even with INDIRECT.rusty
As passed at meeting 2014-05-06: https://lists.oasis-open.org/archives/virtio/201405/msg00016.html Signed-off-by: Rusty Russell <rusty@au1.ibm.com> git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@366 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-15 10:33:39 +0000