Age | Commit message (Collapse) | Author |
|
This will make review easier.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@399 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Add new reviewers and sort by name.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@398 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
List people that provided comments on draft01 in the
acknowledgements section. Might be a nice way to encourage
reviews.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@397 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
using blue does not work well for html
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@396 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Fix wanring when run this shell script.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@395 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
remove fixupdiff.pl, it's unused now
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@394 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Pawel Moll found a way to work around xetex bugs
without mangling latexdiff output using perl:
- define DIFbegin/DIFFend commands in preample
- pass --config FLOATENV= to latexdiff
Use this in preference to the fixupdiff perl script.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@393 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@392 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
- change link color from green to pinegreen. Looks better to me.
- split footnotes out from their text, so that latexdiff
does not consider them as a unit
- mark field command as safe for latexdiff, otherwise it's not shown in red
- hack adding DIFaddtext within footnotes could not handle
case where latexdiff inserted multiple DIFadd within the
footnote. Instead, detect when footnote is within
DIFaddbegin/DIFdelbegin, add an extra DIFaddbegin/DIFdelbegin
within the footnote.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@391 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@390 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Too many \color directives produce corrupted output
and this warning:
WARNING ** Color stack overflow. Just ignore.
Use script to reduce # of these directives.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@389 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
latexdiff adds some
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@388 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
make pdf diff using latexpand and latexdiff-fast
styles are set in diffpreamble.tex
in diff, links are coloured green instead of blue
Must be run within a git-svn clone of the spec repository.
Note: latexdiff has --flatten option, this and options
to select diff style don't seem to work well.
So flatten by script myself, and add our own preamble.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@387 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Make table look better. Drop spaces that make
latexdiff stumble.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@386 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Patch sent to list (and applied by Rusty in
commit fffcbe327c69e510239fff5627034aa2ab4b2d84
pci: switch from subsystem id to device id
) did not actually implement what commit log said
it implements.
The result is wrong for transitional devices:
Adding 0xfff works for for net+block only;
for transitional pci devices there is no fixed scheme:
~/projects/qemu/include # grep VIRTIO_ID hw/virtio/*.h
hw/virtio/virtio-balloon.h:#define VIRTIO_ID_BALLOON 5
hw/virtio/virtio-blk.h:#define VIRTIO_ID_BLOCK 2
hw/virtio/virtio-net.h:#define VIRTIO_ID_NET 1
hw/virtio/virtio-rng.h:#define VIRTIO_ID_RNG 4
hw/virtio/virtio-scsi.h:#define VIRTIO_ID_SCSI 8
hw/virtio/virtio-serial.h:#define VIRTIO_ID_CONSOLE 3
~/projects/qemu/include # grep VIRTIO hw/pci/*.h
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_NET 0x1000
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_BLOCK 0x1001
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_BALLOON 0x1002
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_CONSOLE 0x1003
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_SCSI 0x1004
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_RNG 0x1005
hw/pci/pci.h:#define PCI_DEVICE_ID_VIRTIO_9P 0x1009
I am guessing TC went by commit log when it approved the change,
so fixing it up directly.
Cc: Andrew Thornton <andrewth@google.com>
Cc: Rusty Russell <rusty@ozlabs.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@385 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
This completes the review of virtio-scsi based on observations
from Google.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@384 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Subsystem device ID only exists for PCI.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@383 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
nr_ports does not exist in the spec.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@382 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
The REPORT LUNS well-known logical unit is useful because it lets you
retrieve information about all targets with a single command. It
also provides an easy way to send a no-op request.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@381 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Put the indicator before punctuation, and terminate the footnote with
a period.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@380 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@379 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
pi_bytesin is in the device-readable section. Document lack of residual
field. Use le32 instead of u32.
This matches the new patch series that Nicholas sent for vhost-scsi.
Cc: <nab@daterainc.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@378 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
I chose the one which used the full nomenclature.
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@377 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Switch virtio pci to use standard device id instead of using the
subsystem id.
Unfortunately, there's no system to the way KVM allocated
device IDs to virtio devices, we'll just have to
specify these using a table, and use a new range for
future devices. For existing devices this results in
two possible IDs that all drivers will need to match.
Unfortunate, but the cost is small.
As a nice side effect, this allows us to make non-transitional
devices use IDs 0x40 and up, this reduces even further the
chance that a non transitional device will match legacy drivers.
And, it's probably a good idea to allow drivers to match
specific subsystem IDs if they
want to, so relax requirement for drivers to match all
subsystem/vendor ID configurations, but allow them to do so.
To avoid confusion, say "PCI Device ID" and
"PCI Subsystem ID" everywhere, prefix "PCI"
for other standard registers, for consistency.
VIRTIO-102
Note: issue reporter suggested 0x10XX where XX is the virtio
device ID. This would conflict with legacy devices, which seem
to have used 7 IDs in the range 0x1000 to 0x103f without any
system. Let's use a new range 0x1040 to 0x107f for
non-transitional devices, and add a table documenting the
transitional IDs used by in practice.
(Approved at 2014-06-04 meeting:
https://lists.oasis-open.org/archives/virtio/201406/msg00013.html )
Cc: Andrew Thornton <andrewth@google.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@376 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
config changes are slow path anyway, so we
can as well set ISR bit to help drivers detect changes.
This allows sharing config interrupts which is what
issue reporter seems to ask for.
VIRTIO-104
(Approved at 2014-06-04 meeting:
https://lists.oasis-open.org/archives/virtio/201406/msg00013.html )
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@375 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
If device sets NEEDS_RESET before DRIVER_OK, it
can't send notifications to driver.
Make this clear.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@374 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Error introduced in 59cd205cea "VIRTIO-98: Add DEVICE_NEEDS_RESET":
seems that underscores in labels are verboten:
[133] [134] (./virtio-v1.0-csprd02.aux
! Missing \endcsname inserted.
<to be read again>
\unhbox
l.45 ...ts: Device Status Field}}{subsection.1}{}}
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@373 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As prompted by Rusty, add a few more MUST/SHOULD items for both devices
and drivers. Clarify semantics of max_channel/max_id/max_lun, task_attr
and task management functions.
(As per minutes of meeting 2014-05-20:
https://lists.oasis-open.org/archives/virtio/201405/msg00034.html )
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@372 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
This is a new feature that was suggested by Nicholas Bellinger, who
also provided a prototype implementation for vhost-scsi.
(As per minutes of meeting 2014-05-20:
https://lists.oasis-open.org/archives/virtio/201405/msg00034.html )
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@371 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Assign device id to virtio input
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@370 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@369 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@368 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@367 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@366 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@365 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@364 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As passed at meeting 2014-05-06:
https://lists.oasis-open.org/archives/virtio/201405/msg00016.html
Reported-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Rusty Russell <rusty@au1.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@363 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
For the network device, we had two device normative sections both called
"setting up receive buffers", neither of which was referenced in the
conformance section.
Let's rename the second one to "processing of packets" which seems to
better match the actual contents and reference both of them from the
conformance statement for network devices.
Resolves VIRTIO-97.
Agreed on the 2014/05/06 TC meeting.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@362 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Both device and driver conformance referred to ccw twice; let's add the
correct mmio references.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
(cherry picked from commit feeca2541850c2e1e03ed5ec3b98a5e75ccb4053)
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@361 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
As approved at meeting 2014-03-11:
https://lists.oasis-open.org/archives/virtio/201403/msg00044.html
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@360 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Now that all technicalities have been fixed, tweak REVISION
back to csd02 so it's easy for people to retrieve.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit a03d4573e95f6769e4e1ecafab5c8e39b7cfb7f7)
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@359 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
blow away the zip file, spec file
without extension is never here.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@358 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
makes build more robust
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@357 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
The logic was reverted: it would add OASIS twice,
or never.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@356 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
This reverts commit 1efe46ce1791c7e43940d7f1e2ec0aea8378f670.
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@355 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@354 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Let's be nice to participants.
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@353 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@352 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
makes sure README.txt is first alphabetically
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@351 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|
|
This reverts commit a03d4573e95f6769e4e1ecafab5c8e39b7cfb7f7.
git-svn-id: https://tools.oasis-open.org/version-control/svn/virtio@350 0c8fb4dd-22a2-4bb5-bc14-6c75a5f43652
|