From c78917ee4fe6c787a5de9aaccc5319fdffc9a354 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Tue, 28 Apr 2015 14:20:30 +0100 Subject: modetest: explicitly zero the newly allocated memory Signed-off-by: Emil Velikov Reviewed-by: Alex Deucher --- tests/modetest/modetest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 7f0c1cc1..e4a8bbca 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -1368,8 +1368,6 @@ static int parse_plane(struct plane_arg *plane, const char *p) { char *end; - memset(plane, 0, sizeof *plane); - plane->crtc_id = strtoul(p, &end, 10); if (*end != ':') return -EINVAL; @@ -1541,11 +1539,11 @@ int main(int argc, char **argv) fprintf(stderr, "memory allocation failed\n"); return 1; } + memset(&plane_args[plane_count], 0, sizeof(*plane_args)); if (parse_plane(&plane_args[plane_count], optarg) < 0) usage(argv[0]); - plane_args[plane_count].fb_id = 0; plane_count++; break; case 'p': @@ -1559,6 +1557,7 @@ int main(int argc, char **argv) fprintf(stderr, "memory allocation failed\n"); return 1; } + memset(&pipe_args[count], 0, sizeof(*pipe_args)); if (parse_connector(&pipe_args[count], optarg) < 0) usage(argv[0]); @@ -1578,6 +1577,7 @@ int main(int argc, char **argv) fprintf(stderr, "memory allocation failed\n"); return 1; } + memset(&prop_args[prop_count], 0, sizeof(*prop_args)); if (parse_property(&prop_args[prop_count], optarg) < 0) usage(argv[0]); -- cgit v1.2.3