summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2004-02-21Conditionally add definition of list_for_each_entry_safe for kernelFelix Kuehling
versions that don't have it.
2004-02-20drm_ctx_dtor.patch Submitted by: Erdi ChenKeith Whitwell
2004-02-18Fix sisfb header location for 2.6 kernelsMichel Daenzer
Submitted by: Andrew Morton
2004-01-11Adapt to nopage() prototype change in Linux 2.6.1.Michel Daenzer
Reviewed by: Arjan van de Ven <arjanv@redhat.com>, additional feedback from William Lee Irwin III and Linus Torvalds.
2004-01-10Make sure that all state packets are handled inMichel Daenzer
radeon_check_and_fixup_packets() Fix state packet IDs of R200 cubic offsets
2004-01-10R200_PP_CUBIC_OFFSET_F1_[0-6] state packets only contain 5 offsets, not 6Michel Daenzer
(thanks to Andreas Stenglein for spotting this)
2004-01-06Fix some misuse of NULL where 0 is intended.Eric Anholt
Obtained from: FreeBSD CVS
2003-12-16Don't ioremap the framebuffer area. The ioremapped area wasn't used byEric Anholt
anything, and took up valuable KVA. While I'm in the area, clean up BSD MTRR stuff some more. Suggested by: jonsmirl
2003-12-16Add a collection of Radeon and R128 PCI IDs, including the IGP chipsets.Eric Anholt
Submitted by: Donnie Berkholz <spyderous@gentoo.org> (mostly)
2003-12-08Add i865 pci idKeith Whitwell
2003-11-12Fix a locking nit, and add asserts in some things that should be calledEric Anholt
with locks held.
2003-11-06Return EBUSY when attempting to addmap a DRM_SHM area with a lock in it ifEric Anholt
dev->lock.hw_lock is already set. This fixes the case of two X Servers running on the same head on different VTs with interface 1.1, by making the 2nd head fail to inizialize like before.
2003-11-06Remove unused variable.Eric Anholt
2003-11-05Changes to DRM(irq_install)...... wrap dev->dma usage with __HAVE_DMA inAlan Hourihane
irq handler, fixes kernel ooops. comment out some setting of flags that are done in DRM(setup) (not sure why both of the above is done in the irq handler)
2003-11-05- Tie the DRM to a specific device: setunique no longer succeeds when givenEric Anholt
a busid that doesn't correspond to the device the DRM is attached to. This is a breaking of backwards-compatibility only for the multiple-DRI-head case with X Servers that don't use interface 1.1. - Move irq_busid to drm_irq.h and make it only return the IRQ for the current device. Retains compatibility with previous X Servers, cleans up unnecessary code. This means no irq_busid on !__HAVE_IRQ, but can be changed if necessary. - Bump interface version to 1.2. This version when set signifies that the control ioctl should ignore the irq number passed in and enable the interrupt handler for the attached device. Otherwise it errors out when the passed-in irq is not equal to the device's. - Store the highest version the interface has been set to in the device. - Fix a recursion on DRM_LOCK in irq_uninstall on FreeBSD. This leaves irq_uninstall being done without the lock in some cases, but it was racey anyways.
2003-11-05Use int64_t instead of s64 -- fixes FreeBSD compile, works on linux.Eric Anholt
2003-11-05Args for the BSD DRM_PUT_USER_UNCHECKED were swapped.Eric Anholt
2003-11-05__linux__ is spelled with a lowercase 'l'Eric Anholt
2003-11-05Repo-copy linux/drm/kernel/drm.h to shared/drm/kernel/drm.h and use it onEric Anholt
both Linux and *BSD.
2003-11-05Remove buf_alloc which is unused since the locking commit.Eric Anholt
2003-11-04build fixMichel Daenzer
2003-11-04Memory layout transition:Michel Daenzer
the 2D driver initializes MC_FB_LOCATION and related registers sanely the DRM deduces the layout from these registers clients use the new SETPARAM ioctl to tell the DRM where they think the framebuffer is located in the card's address space the DRM uses all this information to check client state and fix it up if necessary This is a prerequisite for things like direct rendering with IGP chips and video capturing.
2003-11-03Add i852/i855 PCI ID. Also fix whitespace in the other ID definitions.Eric Anholt
2003-10-27Add a DRM_PUT_USER_UNCHECKED, which will be used by an upcoming radeonEric Anholt
change.
2003-10-24Don't try to use dev->dma_lock unless dma is initialized (dev->dma != NULL)Eric Anholt
in bufs_info sysctl handler. dev->dma and dev->dma_lock existence are protected by DRM_LOCK(). Fixes panic on sysctl hw.dri when the device is uninitialied (when you aren't in X).
2003-10-24Switch pci enumeration call to work on both 2.4 and 2.6 pci_for_each_dev isJon Smirl
not supported on 2.6
2003-10-24Move the REALLY_HAVE_AGP endif above the mtrr functions. Broke tdfx module.Eric Anholt
2003-10-23Move to "old-style" probing as documented in linux/Documentation/pci.txt.Eric Anholt
This should resolve the probe problems with radeon framebuffer due to pci_driver attachment being exclusive.
2003-10-23Missed the sis.h header in Makefile.linux in the move to shared/.Eric Anholt
2003-10-23The SiS300 pci id also covers the 305, so make the name reflect that.Eric Anholt
2003-10-23- Introduce a new ioctl, DRM_IOCTL_SET_VERSION. This ioctl allows theEric Anholt
server or client to notify the DRM that it expects a certain version of the device dependent or device independent interface. If the major doesn't match or minor is too large, EINVAL is returned. A major of -1 means that the requestor doesn't care about that portion of the interface. The ioctl returns the actual versions in the same struct. - Introduce DRM DI interface version 1.1. If the server requests version 1.1, then the DRM sets the unique itself according to the busid of the device it probed, which may then be accessed as normal using getunique. - Request version 1.1 in libdrm's drmOpenByBusID, allowing the X Server to request based on a BusID. Introduce a wrapper for DRM_IOCTL_SET_VERSION and bump libdrm minor version. - Pass the busid in DRIScreenInit if libdrm can handle both a busid and name. This allows drmOpenByBusID to be used to find the DRM instead of just the driver name, which allows us in the future to tie a DRM more strongly to the device it probed to. Introduce a function DRICreatePCIBusID which creates a busid in the form pci:oooo:bb:dd.f similar to linux's pci_name() function. This matches the format used by the DRM in version 1.1. libdrm knows how to match both this format and the old PCI:b:d:f format. - Use the new DRICreatePCIBusID function in the *_dri.c to request the new, more exact busid format.
2003-10-22- Add DRM_GET_PRIV_WITH_RETURN macro. This can be used in shared code toEric Anholt
get the drm_file_t * based on the filp passed in ioctl handlers. - Use this macro on BSD for simplification and improve its error reporting. Make failure to find the drm_file_t * print as an error, not debug. This failure may be part of the problem with KDE. - Make debug and error print macros include the pid on BSD.
2003-10-22Fix warning about static DRM(bufs_info) defined but not used in theEric Anholt
!__HAVE_DMA case.
2003-10-20Fix the possibility of sleeping with locks held in sysctls by copying theEric Anholt
data into temporary variables with the lock held then outputting to sysctls with the lock released. Rearranged a little extra code to aid this. Note that drm_memory_debug.h hasn't had this fix applied, but I consider that code to be just about dead anyway.
2003-10-20Clean up BSD MTRR handling. The NetBSD code is untested, but it's my bestEric Anholt
shot.
2003-10-19- SMPng lock the DRM. This is only partial -- there are a few code pathsEric Anholt
used by root (the X Server) which are not locked. However, it should deal with lost-IRQ issues on -current which I think people have been experiencing but I am unable to reproduce (though I understand why they would occur, because of a bug of mine). Note that most of the locking (DRM_LOCK()/UNLOCK()) is all covered by Giant still, so it doesn't matter yet. - Remove locking on FreeBSD-stable and NetBSD. These are covered by the fact that there is no reentrancy of the kernel except by interrupts, which are locked using spldrm()/splx() instead.
2003-10-19Clean up extra zeroing of dev->dma, and use calloc to take advantage ofEric Anholt
M_ZERO.
2003-10-19Fix probing on 2.5+ kernels, which require that drivers have .id_table set.Eric Anholt
We use PCI_ANY_ID to ask that our probe is called for every available device. Submitted by: jonsmirl
2003-10-17- Move IRQ functions from drm_dma.h to new drm_irq.h and disentangle themEric Anholt
from __HAVE_DMA. This will be useful for adding vblank sync support to sis and tdfx. Rename dma_service to irq_handler, which is more accurately what it is. - Fix the #if _HAVE_DMA_IRQ in radeon, r128, mga, i810, i830, gamma to have the right number of underscores. This may have been a problem in the case that the server died without doing its DRM_IOCTL_CONTROL to uninit.
2003-10-17- Converted Linux drivers to initialize DRM instances based on PCI IDs, notEric Anholt
just a single instance. Moved the PCI ID lists from <card>_drv.c in BSD to <card>.h. The PCI ID lists include a driver private field, which may be used by drivers for chip family or other information. Based on work by jonsmirl. - Make tdfx_drv.c and tdfx.h match other drivers. - Fixed up linking of sis shared files. Tested with Radeon and SiS on Linux and FreeBSD, including a Linux setup with 2 SiS cards in a machine, but only one head being used (with DRI)
2003-10-16Introduce COMMIT_RING() as in radeon DRM, stop using error prone writebackMichel Daenzer
for ring read pointer (Paul Mackerras) Get rid of some superfluous stuff, minor fixes
2003-10-16Try that again. It's a long.Eric Anholt
2003-10-16Debug printf format fix.Eric Anholt
2003-10-03Some code cleanups done while working on locking. Reduces always-trueEric Anholt
tests, excessive indenation, convoluted handling of errors, or code duplication.
2003-10-03Stylistic preparation for SMPng locking work: DRM_LOCK/DRM_UNLOCK have sideEric Anholt
effects, so make them look like functions (add parenthesis).
2003-10-02Add an MIT-style copyright, assigned to myself, to these files. I thinkEric Anholt
I've touched enough of the code here, and there was no previous copyright. Do some drive-by style fixes while I'm here.
2003-10-02Axe more old gamma DMA infrastructure.Eric Anholt
2003-10-02Mostly whitespace cleanups and style(9) fixes focused on "if(" -> "if ("Eric Anholt
Change some nearby memset()s to bzero()s or to calloc allocations to take advantage of M_ZERO). Reverse some error tests to reduce high levels of indentation. Move the sg_cleanup() call out of the maplist loop in DRM(takedown)-- I can't see any need for it to be inside.
2003-10-02Wrap sys/endian.h usage with __FreeBSD_version >= 480000.Eric Anholt
Obtained from: i865-agp-0-1-branch
2003-10-02Allow the DRM to attach to a "drmsub" device. This will be provided by theEric Anholt
i810 AGP module, working around the limitation of one driver per device. Obtained from: i865-0-1-branch
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-30 03:22:08 +0000
'>757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 
/*
 * Copyright (C) 2008 Maarten Maathuis.
 * All Rights Reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining
 * a copy of this software and associated documentation files (the
 * "Software"), to deal in the Software without restriction, including
 * without limitation the rights to use, copy, modify, merge, publish,
 * distribute, sublicense, and/or sell copies of the Software, and to
 * permit persons to whom the Software is furnished to do so, subject to
 * the following conditions:
 *
 * The above copyright notice and this permission notice (including the
 * next paragraph) shall be included in all copies or substantial
 * portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 * IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
 * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 *
 */

#include "nv50_kms_wrapper.h"
#include "drm_crtc_helper.h" /* be careful what you use from this */

/* This file serves as the interface between the common kernel modesetting code and the device dependent implementation. */

/*
 * Get private functions.
 */

struct nv50_kms_priv *nv50_get_kms_priv(struct drm_device *dev)
{
	struct drm_nouveau_private *dev_priv = dev->dev_private;
	return dev_priv->kms_priv;
}

/*
 * Allocation functions.
 */

static void *nv50_kms_alloc_crtc(struct drm_device *dev)
{
	struct nv50_kms_priv *kms_priv = nv50_get_kms_priv(dev);
	struct nv50_kms_crtc *crtc = kzalloc(sizeof(struct nv50_kms_crtc), GFP_KERNEL);

	if (!crtc)
		return NULL;

	list_add_tail(&crtc->item, &kms_priv->crtcs);

	return &(crtc->priv);
}

static void *nv50_kms_alloc_output(struct drm_device *dev)
{
	struct nv50_kms_priv *kms_priv = nv50_get_kms_priv(dev);
	struct nv50_kms_encoder *encoder = kzalloc(sizeof(struct nv50_kms_encoder), GFP_KERNEL);

	if (!encoder)
		return NULL;

	list_add_tail(&encoder->item, &kms_priv->encoders);

	return &(encoder->priv);
}

static void *nv50_kms_alloc_connector(struct drm_device *dev)
{
	struct nv50_kms_priv *kms_priv = nv50_get_kms_priv(dev);
	struct nv50_kms_connector *connector = kzalloc(sizeof(struct nv50_kms_connector), GFP_KERNEL);

	if (!connector)
		return NULL;

	list_add_tail(&connector->item, &kms_priv->connectors);

	return &(connector->priv);
}

static void nv50_kms_free_crtc(void *crtc)
{
	struct nv50_kms_crtc *kms_crtc = from_nv50_crtc(crtc);

	list_del(&kms_crtc->item);

	kfree(kms_crtc);
}

static void nv50_kms_free_output(void *output)
{
	struct nv50_kms_encoder *kms_encoder = from_nv50_output(output);

	list_del(&kms_encoder->item);

	kfree(kms_encoder);
}

static void nv50_kms_free_connector(void *connector)
{
	struct nv50_kms_connector *kms_connector = from_nv50_connector(connector);

	list_del(&kms_connector->item);

	kfree(kms_connector);
}

/*
 * Mode conversion functions.
 */

static struct nouveau_hw_mode *nv50_kms_to_hw_mode(struct drm_display_mode *mode)
{
	struct nouveau_hw_mode *hw_mode = kzalloc(sizeof(struct nouveau_hw_mode), GFP_KERNEL);
	if (!hw_mode)
		return NULL;

	/* create hw values. */
	hw_mode->clock = mode->clock;
	hw_mode->flags = hw_mode->flags;

	hw_mode->hdisplay = mode->hdisplay;
	hw_mode->hsync_start = mode->hsync_start;
	hw_mode->hsync_end = mode->hsync_end;
	hw_mode->htotal = mode->htotal;

	hw_mode->hblank_start = mode->hdisplay + 1;
	hw_mode->hblank_end = mode->htotal;

	hw_mode->vdisplay = mode->vdisplay;
	hw_mode->vsync_start = mode->vsync_start;
	hw_mode->vsync_end = mode->vsync_end;
	hw_mode->vtotal = mode->vtotal;

	hw_mode->vblank_start = mode->vdisplay + 1;
	hw_mode->vblank_end = mode->vtotal;

	return hw_mode;
}

/*
 * State mirroring functions.
 */

static void nv50_kms_mirror_routing(struct drm_device *dev)
{
	struct nv50_display *display = nv50_get_display(dev);
	struct nv50_crtc *crtc = NULL;
	struct nv50_output *output = NULL;
	struct nv50_connector *connector = NULL;
	struct drm_connector *drm_connector = NULL;
	struct drm_crtc *drm_crtc = NULL;

	/* Wipe all previous connections. */
	list_for_each_entry(connector, &display->connectors, item) {
		connector->output = NULL;
	}

	list_for_each_entry(output, &display->outputs, item) {
		output->crtc = NULL;
	}

	list_for_each_entry(drm_connector, &dev->mode_config.connector_list, head) {
		if (drm_connector->encoder) {
			output = to_nv50_output(drm_connector->encoder);
			connector = to_nv50_connector(drm_connector);

			/* hook up output to connector. */
			connector->output = output;

			if (drm_connector->encoder->crtc) {
				crtc = to_nv50_crtc(drm_connector->encoder->crtc);

				/* hook up output to crtc. */
				output->crtc = crtc;
			}
		}
	}

	/* mirror crtc active state */
	list_for_each_entry(drm_crtc, &dev->mode_config.crtc_list, head) {
		crtc = to_nv50_crtc(drm_crtc);

		crtc->enabled = drm_crtc->enabled;
	}
}

/*
 * FB functions.
 */

static void nv50_kms_framebuffer_destroy(struct drm_framebuffer *drm_framebuffer)
{
	drm_framebuffer_cleanup(drm_framebuffer);

	kfree(drm_framebuffer);
}

static const struct drm_framebuffer_funcs nv50_kms_fb_funcs = {
	.destroy = nv50_kms_framebuffer_destroy,
};

/*
 * Mode config functions.
 */

static struct drm_framebuffer *nv50_kms_framebuffer_create(struct drm_device *dev,
						struct drm_file *file_priv, struct drm_mode_fb_cmd *mode_cmd)
{
	struct drm_framebuffer *drm_framebuffer = kzalloc(sizeof(struct drm_framebuffer), GFP_KERNEL);
	if (!drm_framebuffer)
		return NULL;

	drm_framebuffer_init(dev, drm_framebuffer, &nv50_kms_fb_funcs);
	drm_helper_mode_fill_fb_struct(drm_framebuffer, mode_cmd);

	return drm_framebuffer;
}

static int nv50_kms_fb_changed(struct drm_device *dev)
{
	return 0; /* not needed until nouveaufb? */
}

static const struct drm_mode_config_funcs nv50_kms_mode_funcs = {
	.resize_fb = NULL,
	.fb_create = nv50_kms_framebuffer_create,
	.fb_changed = nv50_kms_fb_changed,
};

/*
 * CRTC functions.
 */

static int nv50_kms_crtc_cursor_set(struct drm_crtc *drm_crtc, 
				    struct drm_file *file_priv,
				    uint32_t buffer_handle,
				    uint32_t width, uint32_t height)
{
	struct nv50_crtc *crtc = to_nv50_crtc(drm_crtc);
	struct nv50_display *display = nv50_get_display(crtc->dev);
	int rval = 0;

	if (width != 64 || height != 64)
		return -EINVAL;

	/* set bo before doing show cursor */
	if (buffer_handle) {
		rval = crtc->cursor->set_bo(crtc, (drm_handle_t) buffer_handle);
		if (rval != 0)
			goto out;
	}

	crtc->cursor->visible = buffer_handle ? true : false;

	if (buffer_handle) {
		rval = crtc->cursor->show(crtc);
		if (rval != 0)
			goto out;
	} else { /* no handle implies hiding the cursor */
		rval = crtc->cursor->hide(crtc);
		goto out;
	}

	if (rval != 0)
		return rval;

out:
	/* in case this triggers any other cursor changes */
	display->update(display);

	return rval;
}

static int nv50_kms_crtc_cursor_move(struct drm_crtc *drm_crtc, int x, int y)
{
	struct nv50_crtc *crtc = to_nv50_crtc(drm_crtc);

	return crtc->cursor->set_pos(crtc, x, y);
}

void nv50_kms_crtc_gamma_set(struct drm_crtc *drm_crtc, u16 *r, u16 *g, u16 *b,
		uint32_t size)
{
	struct nv50_crtc *crtc = to_nv50_crtc(drm_crtc);

	if (size != 256)
		return;

	crtc->lut->set(crtc, (uint16_t *)r, (uint16_t *)g, (uint16_t *)b);
}

int nv50_kms_crtc_set_config(struct drm_mode_set *set)
{
	int rval = 0, i;
	uint32_t crtc_mask = 0;
	struct drm_device *dev = NULL;
	struct drm_nouveau_private *dev_priv = NULL;
	struct nv50_display *display = NULL;
	struct drm_connector *drm_connector = NULL;
	struct drm_encoder *drm_encoder = NULL;
	struct drm_crtc *drm_crtc = NULL;

	struct nv50_crtc *crtc = NULL;
	struct nv50_output *output = NULL;
	struct nv50_connector *connector = NULL;
	struct nouveau_hw_mode *hw_mode = NULL;
	struct nv50_fb_info fb_info;

	bool blank = false;
	bool switch_fb = false;
	bool modeset = false;

	NV50_DEBUG("\n");

	/*
	 * Supported operations:
	 * - Switch mode.
	 * - Switch framebuffer.
	 * - Blank screen.
	 */

	/* Sanity checking */
	if (!set) {
		DRM_ERROR("Sanity check failed\n");
		goto out;
	}

	if (!set->crtc) {
		DRM_ERROR("Sanity check failed\n");
		goto out;
	}

	if (set->mode) {
		if (set->fb) {
			if (!drm_mode_equal(set->mode, &set->crtc->mode))
				modeset = true;

			if (set->fb != set->crtc->fb)
				switch_fb = true;

			if (set->x != set->crtc->x || set->y != set->crtc->y)
				switch_fb = true;
		}
	} else {
		blank = true;
	}

	if (!set->connectors && !blank) {
		DRM_ERROR("Sanity check failed\n");
		goto out;
	}

	/* Basic variable setting */
	dev = set->crtc->dev;
	dev_priv = dev->dev_private;
	display = nv50_get_display(dev);
	crtc = to_nv50_crtc(set->crtc);

	/**
	 * Wiring up the encoders and connectors.
	 */

	/* for switch_fb we verify if any important changes happened */
	if (!blank) {
		/* Mode validation */
		hw_mode = nv50_kms_to_hw_mode(set->mode);

		rval = crtc->validate_mode(crtc, hw_mode);

		if (rval != MODE_OK) {
			DRM_ERROR("Mode not ok\n");
			goto out;
		}

		for (i = 0; i < set->num_connectors; i++) {
			drm_connector = set->connectors[i];
			if (!drm_connector) {
				DRM_ERROR("No connector\n");
				goto out;
			}
			connector = to_nv50_connector(drm_connector);

			/* This is to ensure it knows the connector subtype. */
			drm_connector->funcs->fill_modes(drm_connector, 0, 0);

			output = connector->to_output(connector, nv50_kms_connector_get_digital(drm_connector));
			if (!output) {
				DRM_ERROR("No output\n");
				goto out;
			}

			rval = output->validate_mode(output, hw_mode);
			if (rval != MODE_OK) {
				DRM_ERROR("Mode not ok\n");
				goto out;
			}

			/* verify if any "sneaky" changes happened */
			if (output != connector->output)
				modeset = true;

			if (output->crtc != crtc)
				modeset = true;
		}
	}

	/* Now we verified if anything changed, fail if nothing has. */
	if (!modeset && !switch_fb && !blank)
		DRM_INFO("A seemingly empty modeset encountered, this could be a bug.\n");

	/* Validation done, move on to cleaning of existing structures. */
	if (modeset) {
		/* find encoders that use this crtc. */
		list_for_each_entry(drm_encoder, &dev->mode_config.encoder_list, head) {
			if (drm_encoder->crtc == set->crtc) {
				/* find the connector that goes with it */
				list_for_each_entry(drm_connector, &dev->mode_config.connector_list, head) {
					if (drm_connector->encoder == drm_encoder) {
						drm_connector->encoder =  NULL;
						break;
					}
				}
				drm_encoder->crtc = NULL;
			}
		}

		/* now find if our desired encoders or connectors are in use already. */
		for (i = 0; i < set->num_connectors; i++) {
			drm_connector = set->connectors[i];
			if (!drm_connector) {
				DRM_ERROR("No connector\n");
				goto out;
			}

			if (!drm_connector->encoder)
				continue;

			drm_encoder = drm_connector->encoder;
			drm_connector->encoder = NULL;

			if (!drm_encoder->crtc)
				continue;

			drm_crtc = drm_encoder->crtc;
			drm_encoder->crtc = NULL;

			drm_crtc->enabled = false;
		}

		/* Time to wire up the public encoder, the private one will be handled later. */
		for (i = 0; i < set->num_connectors; i++) {
			drm_connector = set->connectors[i];
			if (!drm_connector) {
				DRM_ERROR("No connector\n");
				goto out;
			}

			output = connector->to_output(connector, nv50_kms_connector_get_digital(drm_connector));
			if (!output) {
				DRM_ERROR("No output\n");
				goto out;
			}

			/* find the encoder public structure that matches out output structure. */
			drm_encoder = to_nv50_kms_encoder(output);

			if (!drm_encoder) {
				DRM_ERROR("No encoder\n");
				goto out;
			}

			drm_encoder->crtc = set->crtc;
			set->crtc->enabled = true;
			drm_connector->encoder = drm_encoder;
		}
	}

	/**
	 * Disable crtc.
	 */

	if (blank) {
		crtc = to_nv50_crtc(set->crtc);

		set->crtc->enabled = false;

		/* disconnect encoders and connectors */
		for (i = 0; i < set->num_connectors; i++) {
			drm_connector = set->connectors[i];

			if (!drm_connector->encoder)
				continue;

			drm_connector->encoder->crtc = NULL;
			drm_connector->encoder = NULL;
		}
	}

	/**
	 * All state should now be updated, now onto the real work.
	 */

	/* mirror everything to the private structs */
	nv50_kms_mirror_routing(dev);

	/**
	 * Bind framebuffer.
	 */

	if (switch_fb) {
		crtc = to_nv50_crtc(set->crtc);

		/* set framebuffer */
		set->crtc->fb = set->fb;

		/* set private framebuffer */
		crtc = to_nv50_crtc(set->crtc);
		fb_info.block = find_block_by_handle(dev_priv->fb_heap, set->fb->mm_handle);
		fb_info.width = set->fb->width;
		fb_info.height = set->fb->height;
		fb_info.depth = set->fb->depth;
		fb_info.bpp = set->fb->bits_per_pixel;
		fb_info.pitch = set->fb->pitch;
		fb_info.x = set->x;
		fb_info.y = set->y;

		rval = crtc->fb->bind(crtc, &fb_info);
		if (rval != 0) {
			DRM_ERROR("fb_bind failed\n");
			goto out;
		}
	}

	/* this is !cursor_show */
	if (!crtc->cursor->enabled) {
		rval = crtc->cursor->enable(crtc);
		if (rval != 0) {
			DRM_ERROR("cursor_enable failed\n");
			goto out;
		}
	}

	/**
	 * Blanking.
	 */

	if (blank) {
		crtc = to_nv50_crtc(set->crtc);

		rval = crtc->blank(crtc, true);
		if (rval != 0) {
			DRM_ERROR("blanking failed\n");
			goto out;
		}

		/* detach any outputs that are currently unused */
		list_for_each_entry(drm_encoder, &dev->mode_config.encoder_list, head) {
			if (!drm_encoder->crtc) {
				output = to_nv50_output(drm_encoder);

				rval = output->execute_mode(output, true);
				if (rval != 0) {
					DRM_ERROR("detaching output failed\n");
					goto out;
				}
			}
		}
	}

	/**
	 * Change framebuffer, without changing mode.
	 */

	if (switch_fb && !modeset && !blank) {
		crtc = to_nv50_crtc(set->crtc);

		rval = crtc->set_fb(crtc);
		if (rval != 0) {
			DRM_ERROR("set_fb failed\n");
			goto out;
		}

		/* this also sets the fb offset */
		rval = crtc->blank(crtc, false);
		if (rval != 0) {
			DRM_ERROR("unblanking failed\n");
			goto out;
		}
	}

	/**
	 * Normal modesetting.
	 */

	if (modeset) {
		crtc = to_nv50_crtc(set->crtc);

		/* disconnect unused outputs */
		list_for_each_entry(output, &display->outputs, item) {
			if (output->crtc) {
				crtc_mask |= 1 << output->crtc->index;
			} else {
				rval = output->execute_mode(output, true);
				if (rval != 0) {
					DRM_ERROR("detaching output failed\n");
					goto out;
				}
			}
		}

		/* blank any unused crtcs */
		list_for_each_entry(crtc, &display->crtcs, item) {
			if (!(crtc_mask & (1 << crtc->index)))
				crtc->blank(crtc, true);
		}

		crtc = to_nv50_crtc(set->crtc);

		rval = crtc->set_mode(crtc, hw_mode);
		if (rval != 0) {
			DRM_ERROR("crtc mode set failed\n");
			goto out;
		}

		/* find native mode. */
		list_for_each_entry(output, &display->outputs, item) {
			if (output->crtc != crtc)
				continue;

			*crtc->native_mode = *output->native_mode;
			list_for_each_entry(connector, &display->connectors, item) {
				if (connector->output != output)
					continue;

				crtc->requested_scaling_mode = connector->requested_scaling_mode;
				crtc->use_dithering = connector->use_dithering;
				break;
			}

			if (crtc->requested_scaling_mode == SCALE_NON_GPU)
				crtc->use_native_mode = false;
			else
				crtc->use_native_mode = true;

			break; /* no use in finding more than one mode */
		}

		rval = crtc->execute_mode(crtc);
		if (rval != 0) {
			DRM_ERROR("crtc execute mode failed\n");
			goto out;
		}

		list_for_each_entry(output, &display->outputs, item) {
			if (output->crtc != crtc)
				continue;

			rval = output->execute_mode(output, false);
			if (rval != 0) {
				DRM_ERROR("output execute mode failed\n");
				goto out;
			}
		}

		rval = crtc->set_scale(crtc);
		if (rval != 0) {
			DRM_ERROR("crtc set scale failed\n");
			goto out;
		}

		/* next line changes crtc, so putting it here is important */
		display->last_crtc = crtc->index;
	}

	/* always reset dpms, regardless if any other modesetting is done. */
	if (!blank) {
		/* this is executed immediately */
		list_for_each_entry(output, &display->outputs, item) {
			if (output->crtc != crtc)
				continue;

			rval = output->set_power_mode(output, DRM_MODE_DPMS_ON);
			if (rval != 0) {
				DRM_ERROR("output set power mode failed\n");
				goto out;
			}
		}

		/* update dpms state to DPMSModeOn */
		for (i = 0; i < set->num_connectors; i++) {
			drm_connector = set->connectors[i];
			if (!drm_connector) {
				DRM_ERROR("No connector\n");
				goto out;
			}

			rval = drm_connector_property_set_value(drm_connector,
					dev->mode_config.dpms_property,
					DRM_MODE_DPMS_ON);
			if (rval != 0) {
				DRM_ERROR("failed to update dpms state\n");
				goto out;
			}
		}
	}

	display->update(display);

	/* Update the current mode, now that all has gone well. */
	if (modeset) {
		set->crtc->mode = *(set->mode);
		set->crtc->x = set->x;
		set->crtc->y = set->y;
	}

	kfree(hw_mode);

	return 0;

out:
	kfree(hw_mode);

	if (rval != 0)
		return rval;
	else
		return -EINVAL;
}

static void nv50_kms_crtc_destroy(struct drm_crtc *drm_crtc)
{
	struct nv50_crtc *crtc = to_nv50_crtc(drm_crtc);

	drm_crtc_cleanup(drm_crtc);

	/* this will even destroy the public structure. */
	crtc->destroy(crtc);
}

static const struct drm_crtc_funcs nv50_kms_crtc_funcs = {
	.save = NULL,
	.restore = NULL,
	.cursor_set = nv50_kms_crtc_cursor_set,
	.cursor_move = nv50_kms_crtc_cursor_move,
	.gamma_set = nv50_kms_crtc_gamma_set,
	.set_config = nv50_kms_crtc_set_config,
	.destroy = nv50_kms_crtc_destroy,
};

static int nv50_kms_crtcs_init(struct drm_device *dev)
{
	struct nv50_display *display = nv50_get_display(dev);
	struct nv50_crtc *crtc = NULL;

	/*
	 * This may look a bit confusing, but:
	 * The internal structure is already allocated and so is the public one.
	 * Just a matter of getting to the memory and register it.
	 */
	list_for_each_entry(crtc, &display->crtcs, item) {
		struct drm_crtc *drm_crtc = to_nv50_kms_crtc(crtc);

		drm_crtc_init(dev, drm_crtc, &nv50_kms_crtc_funcs);

		/* init lut storage */
		drm_mode_crtc_set_gamma_size(drm_crtc, 256);
	}

	return 0;
}

/*
 * Encoder functions
 */

static void nv50_kms_encoder_destroy(struct drm_encoder *drm_encoder)
{
	struct nv50_output *output = to_nv50_output(drm_encoder);

	drm_encoder_cleanup(drm_encoder);

	/* this will even destroy the public structure. */
	output->destroy(output);
}

static const struct drm_encoder_funcs nv50_kms_encoder_funcs = {
	.destroy = nv50_kms_encoder_destroy,
};

static int nv50_kms_encoders_init(struct drm_device *dev)
{
	struct nv50_display *display = nv50_get_display(dev);
	struct nv50_output *output = NULL;

	list_for_each_entry(output, &display->outputs, item) {
		struct drm_encoder *drm_encoder = to_nv50_kms_encoder(output);
		uint32_t type = DRM_MODE_ENCODER_NONE;

		switch (output->type) {
			case OUTPUT_DAC:
				type = DRM_MODE_ENCODER_DAC;
				break;
			case OUTPUT_TMDS:
				type = DRM_MODE_ENCODER_TMDS;
				break;
			case OUTPUT_LVDS:
				type = DRM_MODE_ENCODER_LVDS;
				break;
			case OUTPUT_TV:
				type = DRM_MODE_ENCODER_TVDAC;
				break;
			default:
				type = DRM_MODE_ENCODER_NONE;
				break;
		}

		if (type == DRM_MODE_ENCODER_NONE) {
			DRM_ERROR("DRM_MODE_ENCODER_NONE encountered\n");
			continue;
		}

		drm_encoder_init(dev, drm_encoder, &nv50_kms_encoder_funcs, type);

		/* I've never seen possible crtc's restricted. */
		drm_encoder->possible_crtcs = 3;
		drm_encoder->possible_clones = 0;
	}

	return 0;
}

/*
 * Connector functions
 */


/* These 2 functions wrap the connector properties that deal with multiple encoders per connector. */
bool nv50_kms_connector_get_digital(struct drm_connector *drm_connector)
{
	struct drm_device *dev = drm_connector->dev;

	switch (drm_connector->connector_type) {
		case DRM_MODE_CONNECTOR_VGA:
		case DRM_MODE_CONNECTOR_SVIDEO:
			return false;
		case DRM_MODE_CONNECTOR_DVID:
		case DRM_MODE_CONNECTOR_LVDS:
			return true;
		default:
			break;
	}

	if (drm_connector->connector_type == DRM_MODE_CONNECTOR_DVII) {
		int rval;
		uint64_t prop_val;

		rval = drm_connector_property_get_value(drm_connector, dev->mode_config.dvi_i_select_subconnector_property, &prop_val);
		if (rval) {
			DRM_ERROR("Unable to find select subconnector property, defaulting to DVI-D\n");
			return true;
		}

		/* Is a subconnector explicitly selected? */
		switch (prop_val) {
			case DRM_MODE_SUBCONNECTOR_DVID:
				return true;
			case DRM_MODE_SUBCONNECTOR_DVIA:
				return false;
			default:
				break;
		}

		rval = drm_connector_property_get_value(drm_connector, dev->mode_config.dvi_i_subconnector_property, &prop_val);
		if (rval) {
			DRM_ERROR("Unable to find subconnector property, defaulting to DVI-D\n");
			return true;
		}

		/* Do we know what subconnector we currently have connected? */
		switch (prop_val) {
			case DRM_MODE_SUBCONNECTOR_DVID:
				return true;
			case DRM_MODE_SUBCONNECTOR_DVIA:
				return false;
			default:
				DRM_ERROR("Unknown subconnector value, defaulting to DVI-D\n");
				return true;
		}
	}

	DRM_ERROR("Unknown connector type, defaulting to analog\n");
	return false;
}

static void nv50_kms_connector_set_digital(struct drm_connector *drm_connector, int digital, bool force)
{
	struct drm_device *dev = drm_connector->dev;

	if (drm_connector->connector_type == DRM_MODE_CONNECTOR_DVII) {
		uint64_t cur_value, new_value;

		int rval = drm_connector_property_get_value(drm_connector, dev->mode_config.dvi_i_subconnector_property, &cur_value);
		if (rval) {
			DRM_ERROR("Unable to find subconnector property\n");
			return;
		}

		/* Only set when unknown or when forced to do so. */
		if (cur_value != DRM_MODE_SUBCONNECTOR_Unknown && !force)
			return;

		if (digital == 1)
			new_value = DRM_MODE_SUBCONNECTOR_DVID;
		else if (digital == 0)
			new_value = DRM_MODE_SUBCONNECTOR_DVIA;
		else
			new_value = DRM_MODE_SUBCONNECTOR_Unknown;
		drm_connector_property_set_value(drm_connector, dev->mode_config.dvi_i_subconnector_property, new_value);
	}
}

void nv50_kms_connector_detect_all(struct drm_device *dev)
{
	struct drm_connector *drm_connector = NULL;

	list_for_each_entry(drm_connector, &dev->mode_config.connector_list, head) {
		drm_connector->funcs->detect(drm_connector);
	}
}

static enum drm_connector_status nv50_kms_connector_detect(struct drm_connector *drm_connector)
{
	struct drm_device *dev = drm_connector->dev;
	struct nv50_connector *connector = to_nv50_connector(drm_connector);
	struct nv50_output *output = NULL;
	int hpd_detect = 0, load_detect = 0, i2c_detect = 0;
	int old_status = drm_connector->status;

	/* hotplug detect */
	hpd_detect = connector->hpd_detect(connector);

	/* load detect */
	output = connector->to_output(connector, false); /* analog */
	if (output && output->detect)
		load_detect = output->detect(output);

	if (hpd_detect < 0 || load_detect < 0) /* did an error occur? */
		i2c_detect = connector->i2c_detect(connector);

	if (load_detect == 1) {
		nv50_kms_connector_set_digital(drm_connector, 0, true); /* analog, forced */
	} else if (hpd_detect == 1 && load_detect == 0) {
		nv50_kms_connector_set_digital(drm_connector, 1, true); /* digital, forced */
	} else {
		nv50_kms_connector_set_digital(drm_connector, -1, true); /* unknown, forced */
	}

	if (hpd_detect == 1 || load_detect == 1 || i2c_detect == 1)
		drm_connector->status = connector_status_connected;
	else
		drm_connector->status = connector_status_disconnected;

	/* update our modes whenever there is reason to */
	if (old_status != drm_connector->status) {
		drm_connector->funcs->fill_modes(drm_connector, 0, 0);

		/* notify fb of changes */
		dev->mode_config.funcs->fb_changed(dev);

		/* sent a hotplug event when appropriate. */
		drm_sysfs_hotplug_event(dev);
	}

	return drm_connector->status;
}

static void nv50_kms_connector_destroy(struct drm_connector *drm_connector)
{
	struct nv50_connector *connector = to_nv50_connector(drm_connector);

	drm_sysfs_connector_remove(drm_connector);
	drm_connector_cleanup(drm_connector);

	/* this will even destroy the public structure. */
	connector->destroy(connector);
}

/*
 * Detailed mode info for a standard 640x480@60Hz monitor
 */
static struct drm_display_mode std_mode[] = {
	/*{ DRM_MODE("640x480", DRM_MODE_TYPE_DEFAULT, 25200, 640, 656,
		 752, 800, 0, 480, 490, 492, 525, 0,
		 DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) },*/ /* 640x480@60Hz */
	{ DRM_MODE("1280x1024", DRM_MODE_TYPE_DEFAULT, 135000, 1280, 1296,
		   1440, 1688, 0, 1024, 1025, 1028, 1066, 0,
		   DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1280x1024@75Hz */
};

static void nv50_kms_connector_fill_modes(struct drm_connector *drm_connector, uint32_t maxX, uint32_t maxY)
{
	struct nv50_connector *connector = to_nv50_connector(drm_connector);
	struct drm_device *dev = drm_connector->dev;
	int rval = 0;
	bool connected = false;
	struct drm_display_mode *mode, *t;
	struct edid *edid = NULL;

	NV50_DEBUG("%s\n", drm_get_connector_name(drm_connector));
	/* set all modes to the unverified state */
	list_for_each_entry_safe(mode, t, &drm_connector->modes, head)
		mode->status = MODE_UNVERIFIED;

	if (nv50_kms_connector_detect(drm_connector) == connector_status_connected)
		connected = true;

	if (connected)
		NV50_DEBUG("%s is connected\n", drm_get_connector_name(drm_connector));
	else
		NV50_DEBUG("%s is disconnected\n", drm_get_connector_name(drm_connector));

	/* Not all connnectors have an i2c channel. */
	if (connected && connector->i2c_chan)
		edid = (struct edid *) drm_do_probe_ddc_edid(&connector->i2c_chan->adapter);

	/* This will remove edid if needed. */
	drm_mode_connector_update_edid_property(drm_connector, edid);

	if (edid) {
		rval = drm_add_edid_modes(drm_connector, edid);

		/* Only update when relevant and when detect couldn't determine type. */
		nv50_kms_connector_set_digital(drm_connector, edid->digital ? 1 : 0, false);

		kfree(edid);
	}

	if (rval) /* number of modes  > 1 */
		drm_mode_connector_list_update(drm_connector);

	if (maxX && maxY)
		drm_mode_validate_size(dev, &drm_connector->modes, maxX, maxY, 0);

	list_for_each_entry_safe(mode, t, &drm_connector->modes, head) {
		if (mode->status == MODE_OK) {
			struct nouveau_hw_mode *hw_mode = nv50_kms_to_hw_mode(mode);
			struct nv50_output *output = connector->to_output(connector, nv50_kms_connector_get_digital(drm_connector));

			mode->status = output->validate_mode(output, hw_mode);
			/* find native mode, TODO: also check if we actually found one */
			if (mode->status == MODE_OK) {
				if (mode->type & DRM_MODE_TYPE_PREFERRED)
					*output->native_mode = *hw_mode;
			}
			kfree(hw_mode);
		}
	}

	/* revalidate now that we have native mode */
	list_for_each_entry_safe(mode, t, &drm_connector->modes, head) {
		if (mode->status == MODE_OK) {
			struct nouveau_hw_mode *hw_mode = nv50_kms_to_hw_mode(mode);
			struct nv50_output *output = connector->to_output(connector, nv50_kms_connector_get_digital(drm_connector));

			mode->status = output->validate_mode(output, hw_mode);
			kfree(hw_mode);
		}
	}

	drm_mode_prune_invalid(dev, &drm_connector->modes, true);

	/* pruning is done, so bail out. */
	if (!connected)
		return;

	if (list_empty(&drm_connector->modes)) {
		struct drm_display_mode *stdmode;
		struct nouveau_hw_mode *hw_mode;
		struct nv50_output *output;

		NV50_DEBUG("No valid modes on %s\n", drm_get_connector_name(drm_connector));

		/* Making up native modes for LVDS is a bad idea. */
		if (drm_connector->connector_type == DRM_MODE_CONNECTOR_LVDS)
			return;

		/* Should we do this here ???
		 * When no valid EDID modes are available we end up
		 * here and bailed in the past, now we add a standard
		 * 640x480@60Hz mode and carry on.
		 */
		stdmode = drm_mode_duplicate(dev, &std_mode[0]);
		drm_mode_probed_add(drm_connector, stdmode);
		drm_mode_list_concat(&drm_connector->probed_modes,
				     &drm_connector->modes);

		/* also add it as native mode */
		hw_mode = nv50_kms_to_hw_mode(mode);
		output = connector->to_output(connector, nv50_kms_connector_get_digital(drm_connector));

		if (hw_mode)
			*output->native_mode = *hw_mode;

		DRM_DEBUG("Adding standard 640x480 @ 60Hz to %s\n",
			  drm_get_connector_name(drm_connector));
	}

	drm_mode_sort(&drm_connector->modes);

	NV50_DEBUG("Probed modes for %s\n", drm_get_connector_name(drm_connector));

	list_for_each_entry_safe(mode, t, &drm_connector->modes, head) {
		mode->vrefresh = drm_mode_vrefresh(mode);

		/* is this needed, as it's unused by the driver? */
		drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
		drm_mode_debug_printmodeline(mode);
	}
}

static int nv50_kms_connector_set_property(struct drm_connector *drm_connector,
					struct drm_property *property,
					uint64_t value)
{
	struct drm_device *dev = drm_connector->dev;
	struct nv50_connector *connector = to_nv50_connector(drm_connector);
	int rval = 0;
	bool delay_change = false;

	/* DPMS */
	if (property == dev->mode_config.dpms_property && drm_connector->encoder) {
		struct nv50_output *output = to_nv50_output(drm_connector->encoder);

		rval = output->set_power_mode(output, (int) value);

		return rval;
	}

	/* Scaling mode */
	if (property == dev->mode_config.scaling_mode_property) {
		struct nv50_crtc *crtc = NULL;
		struct nv50_display *display = nv50_get_display(dev);
		int internal_value = 0;

		switch (value) {
			case DRM_MODE_SCALE_NON_GPU:
				internal_value = SCALE_NON_GPU;
				break;
			case DRM_MODE_SCALE_FULLSCREEN:
				internal_value = SCALE_FULLSCREEN;
				break;
			case DRM_MODE_SCALE_NO_SCALE:
				internal_value = SCALE_NOSCALE;
				break;
			case DRM_MODE_SCALE_ASPECT:
				internal_value = SCALE_ASPECT;
				break;
			default:
				break;
		}

		/* LVDS always needs gpu scaling */
		if (connector->type == CONNECTOR_LVDS && internal_value == SCALE_NON_GPU)
			return -EINVAL;

		connector->requested_scaling_mode = internal_value;

		if (drm_connector->encoder && drm_connector->encoder->crtc)
			crtc = to_nv50_crtc(drm_connector->encoder->crtc);

		if (!crtc)
			return 0;

		crtc->requested_scaling_mode = connector->requested_scaling_mode;

		/* going from and to a gpu scaled regime requires a modesetting, so wait until next modeset */
		if (crtc->scaling_mode == SCALE_NON_GPU || internal_value == SCALE_NON_GPU) {
			DRM_INFO("Moving from or to a non-gpu scaled mode, this will be processed upon next modeset.");
			delay_change = true;
		}

		if (delay_change)
			return 0;

		rval = crtc->set_scale(crtc);
		if (rval)
			return rval;

		/* process command buffer */
		display->update(display);

		return 0;
	}

	/* Dithering */
	if (property == dev->mode_config.dithering_mode_property) {
		struct nv50_crtc *crtc = NULL;
		struct nv50_display *display = nv50_get_display(dev);

		if (value == DRM_MODE_DITHERING_ON)
			connector->use_dithering = true;
		else
			connector->use_dithering = false;

		if (drm_connector->encoder && drm_connector->encoder->crtc)